Skip to content

No sound played without this fix on window#174

Merged
vvolhejn merged 1 commit into
kyutai-labs:mainfrom
dtesniere:fix/tts_pytorch_streaming_win_hooked
Jan 26, 2026
Merged

No sound played without this fix on window#174
vvolhejn merged 1 commit into
kyutai-labs:mainfrom
dtesniere:fix/tts_pytorch_streaming_win_hooked

Conversation

@dtesniere

Copy link
Copy Markdown
Contributor

(pre-commit hook done)

Checklist

  • [ X ] Read CONTRIBUTING.md, and accept the CLA by including the provided snippet. We will not accept PR without this.
  • [ X ] Run pre-commit hook.
  • [ X ] If you changed Rust code, run cargo check, cargo clippy, cargo test.

PR Description

Hello,

I'm not sur at all it will be helpfull for you because I'm on window.
(I replace "triton" lib by "triton-windows" from pypi)

I notice this bug that prevent me to ear any sound in the tts_pytorch_streaming.py example.
So I would like to share it. I hope it will help.

Here is a "more readable" content of the fix (before pre-hook git commit and ruff formatter):
image

Notes:

  • I find the problem with the help from claude sonnet 4.5 using github copilot
  • I'm not an expert in Python devs
  • I didn't change anything on RUST code so I don't run cargo check, cargo clippy, cargo test.

@vvolhejn vvolhejn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that looks like a bug indeed! Thanks for the fix

@vvolhejn vvolhejn merged commit 4c4f65e into kyutai-labs:main Jan 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants