Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a generic dockerfile which can be used to create a docker image using any available rocm release for any gpu.
Here's how it works
docker build -t llama-cpp-rocm7.0rc -f Dockerfile.rocm-generic . --no-cache --build-arg GFX=gfx1151 --build-arg ROCM_MAJOR_VER=7 --build-arg ROCM_MINOR_VER=0 --build-arg ROCM_PATH_VER=0 --build-arg REV=rcThis will be build an image with RC version of rocm. The same way we can build an image for gfx1150 with rocm 7.11
docker build -t llama-cpp-rocm7.10a -f Dockerfile.rocm-generic . --no-cache --build-arg GFX=gfx1150 --build-arg ROCM_MAJOR_VER=7 --build-arg ROCM_MINOR_VER=11 --build-arg ROCM_PATH_VER=0 --build-arg REV=aThis way there's no need to have a dockerfile per rocm version (probably the ones which require specific build arguments will still be needed)
Also I'm not sure how it works with toolbox since I am not using it, but in worst case it's surely possible to build images first and then use them with toolbox (it seems like an option according to docs)