Skip to content

Conversation

@bakunowski
Copy link

Related Issue(s)

This is required for kyverno/kyverno#12117 to be merged.

Description

This PR fixes two tests that rely on wrong Kyverno behaviour.

In the case of allowed-label-changes:

In the case of prepend-image-registry:

  • I'm not entirely sure what the fail case for a mutating policy is, apart from the webhook being unavailable. We could probably fake it with a resource.operation set to something other than CREATE or UPDATE, but I've decided to delete the result: fail tests, and leave the tests checking if mutation happened correctly.

Checklist

  • I have read the policy contribution guidelines.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended. (with the caveat of the mutating policy)
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@JimBugwadia
Copy link
Member

@bakunowski - can you please help fix the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants