Skip to content

stupid commit to test CI #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kzubatov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

stupid commit to test CI #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions samples/shadowmap/App.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ App::App()
auto instExts = windowing.getRequiredVulkanInstanceExtensions();
renderer->initVulkan(instExts);

auto surface = mainWindow->createVkSurface(etna::get_context().getInstance());
auto surface_ = mainWindow->createVkSurface(etna::get_context().getInstance());
Copy link
Copy Markdown

@github-actions github-actions bot Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: invalid case style for variable 'surface_' [readability-identifier-naming]

Suggested change
auto surface_ = mainWindow->createVkSurface(etna::get_context().getInstance());
auto surface = mainWindow->createVkSurface(etna::get_context().getInstance());

samples/shadowmap/App.cpp:36:

-     std::move(surface_), [window = mainWindow.get()]() { return window->getResolution(); });
+     std::move(surface), [window = mainWindow.get()]() { return window->getResolution(); });


renderer->initFrameDelivery(
std::move(surface), [window = mainWindow.get()]() { return window->getResolution(); });
std::move(surface_), [window = mainWindow.get()]() { return window->getResolution(); });

// TODO: this is bad design, this initialization is dependent on the current ImGui context, but we
// pass it implicitly here instead of explicitly. Beware if trying to do something tricky.
Expand Down
Loading