Skip to content

Middle out #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
May 3, 2024
Merged

Middle out #7

merged 17 commits into from
May 3, 2024

Conversation

martyall
Copy link
Member

@martyall martyall commented May 3, 2024

  • add hash cons sharing for expressions (see Node type in Circuit.Language.Expr)
  • drastically simply the compile phase taking advantage of the output of reifyGraph is already (reverse) topologically sorted
  • simplify the functions for inputing/returning bools/fields
  • add the Unbundled type class
  • added partial implementation/test for SHA3 that won't run because something is way too slow.

In addition, I ran the profiler many times to understand where things were slowed down and some adjustments were made:

  • Use IntSet and IntMap ubiquitously where possible
  • create the InputBindings type to manage labled vars
  • add INLINE pragams in a bunch of places

@martyall martyall merged commit 1e16a0c into master May 3, 2024
2 checks passed
@martyall martyall deleted the middle-out branch May 7, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant