Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

Missing styles fix#205

Open
ghost wants to merge 38 commits intomasterfrom
unknown repository
Open

Missing styles fix#205
ghost wants to merge 38 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jan 11, 2019

  • Channel setting's additional options and edit message retention modal style missing fix
  • search modal files list missing style fix

Copy link
Copy Markdown
Collaborator

@mastermel mastermel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my follow up comments, and also make the changes requested by the linter. Please don't simply resolve the linter's comments. It helps keep the codebase consistent to follow these suggestions. If you feel like any of the linter rules are unnecessary than please submit a separate PR with your suggested changes there.

Thanks!

@import "modules/pages/legal";
@import "modules/pages/oauth";
@import "modules/pages/spaces";
@import "modules/pages/spaces"; No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline


.p-unreads_view {
background: $color-base;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants