scripts/ImportPSX_SYM: Don't assume that a ChunkSLDFilenameSet32 exists #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually this parses the types (and prints func addrs/names with a println I have locally) but doesn't actually import them, hm |
Running into a parser null ref exception on a sym file without this change (it only had tag types 0x1 and 0x2).
Contributor
Author
|
Should be ok now. |
dreamsyntax
approved these changes
Sep 2, 2025
Collaborator
dreamsyntax
left a comment
dreamsyntax
left a comment
There was a problem hiding this comment.
Looks fine; Untested.
Contributor
Author
|
fwiw I did test the final pushed version, though on my sym file, not on one containing ChunkSLDFilenameSet32 |
Collaborator
I dont have one, could add it as a second branch on fail or as a toggle/other op to be safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into a parser null ref exception on a sym file without this change (it only had tag types 0x1 and 0x2).