Skip to content

fix notifications (Fix #453) #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

Zahnstocher
Copy link
Contributor

No description provided.

@Andyporras
Copy link
Member

Hi @Zahnstocher ,

I tested the PR "Fix notifications (Fix #453)," and I can confirm that it works well both in the current version and with the updated API in PR #457 (target SDK 35). Great work.

However, I noticed that the pull request is targeting the master branch instead of develop. Could you please update the target branch to develop to ensure proper integration?

@Binnette Binnette changed the base branch from master to develop November 18, 2024 13:53
@Binnette Binnette merged commit 1114efe into labexp:develop Nov 18, 2024
@Binnette Binnette mentioned this pull request Nov 22, 2024
@Binnette Binnette added this to the 2024.12 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants