Skip to content

Scrollview available layouts #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

Binnette
Copy link
Collaborator

Add a simple scrollview to make the "Available layouts" view scrollable. Yes there are too much buttons for my screen.

Screen_recording_20241028_001123.mp4

@Binnette
Copy link
Collaborator Author

Hi @jamescr, If needed, you can add me as repo maintainer. I will be happy to review, test and merge the PR. And also triage bug and so on. I am developer and did Android development as well.
For more info, feel free to visit my GitHub Profile or Osm Profile.

@Binnette
Copy link
Collaborator Author

BTW, you should merge #448 first to fix Gradle download issue in Android Studio.

@jamescr
Copy link
Member

jamescr commented Nov 8, 2024

@Binnette could you change the target branch of the PR to develop?

@Andyporras
Copy link
Member

Andyporras commented Nov 13, 2024

Hi @Binnette,

Great work on the PR “Scrollview available layouts #456.” The ScrollView implementation works seamlessly in the current version and is also fully compatible with the changes in PR #457 (target SDK 35). It’s an effective solution for handling screens with a large number of buttons.

However, as per @jamescr comment, could you please change the target branch of this PR from master to develop? This will ensure smoother integration and alignment with the project's workflow.

@Binnette Binnette changed the base branch from master to develop November 18, 2024 13:51
@Binnette Binnette merged commit 70fb5c5 into labexp:develop Nov 18, 2024
@Binnette Binnette added this to the 2024.12 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants