-
Notifications
You must be signed in to change notification settings - Fork 239
preview, edit and delete waypoints (#67, #328) #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR will be paused until #508 in merged. |
📢 Bug found on Android 15 @Kevin-Salazar-itcr Hi! I tested the functionality and found an issue on Android 15:
It seems like there's a restriction when handling older images. Could you check this? Let me know if you need more details or testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kevin-Salazar-itcr ! Thanks for the functionality. Definitively is a nice function to have. I found some errors:
- When the user clicks the "Text note" button and then cancels the note, the app fails and the text note is saved.
- If a photo in the waypoint list has a vertical orientation, part of its content isn't visible because it is displayed with a horizontal layout.
- OSMTracker fails when a photo waypoint is too large and the user tries to preview it.
- When the waypoint is a photo and the phone is in landscape orientation, the update, delete, and cancel buttons are not shown, and the text input is not displayed properly.
Cell phones already have an image viewer and an audio player. What do you think about delegating the "Play audio" and "View photo" actions to them? Graphically, it would be similar: when the user clicks "Play audio," the device's audio player opens; similarly, for photos, we could show a "View photo" button instead of displaying the photo directly. What do you think, @Kevin-Salazar-itcr ?
Benefits:
- Lower resources consumption.
- Photos with zoom capability.
- Audio slider to move forward or backward in the voice note.
- Address observations 2, 3 and 4
Hi @Andyporras, this new version uses an unique ID to handle how works these new functionalities, so, if you have old tracks with waypoints, these won't handle the update. Example: |
Hi @Kevin-Salazar-itcr, another issue found: when the text is too large, the cancel button is displayed incorrectly. (API 25): |
> Usability performed for landscape mode and zoomed fonts > Preview using external apps > Fixed: canceling text note creation caused an app crash
I just tested the latest changes. Everything works as expected in Android 15! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kevin-Salazar-itcr! I commented some improvements in the code. Aditionally can you please match the color of the modal with the window and move the update, delete and cancel bottons a little bit up. See the screenshoot:
Hi @FR3DD221, @Andyporras, @miltonials thanks for your comments, during yesterday i've resolved these bugs. If you have any suggestion feel free to comment here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kevin-Salazar-itcr thanks for the changes! Is working well with API25. Just fix the typo. 😉
daebede
to
679400e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job. Is working well with API35 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I´m just test the last commit and didn´t see any issue.
679400e
to
7de7afe
Compare
7de7afe
to
3f46d3f
Compare
70430e4
to
6a083c9
Compare
Refactoring of constants and update with upstream develop branch
This PR is a continuation of PRs #39 and #171, which were incomplete.
The following features have been added for waypoint management: