fix: drop distinction between rand and random function in NEM#366
Open
samuelortion wants to merge 1 commit intolabgem:devfrom
Open
fix: drop distinction between rand and random function in NEM#366samuelortion wants to merge 1 commit intolabgem:devfrom
samuelortion wants to merge 1 commit intolabgem:devfrom
Conversation
On gcc 15, using -std=c99 (as set in setup.py, for NEM c source compilation), the random function is not defined. (at least this is the case on Fedora 43). According to stdlib.h file, both rand and random function uses the same generator in glibc implementation. > /* These are the functions that actually do things. The `random\', `srandom', > `initstate' and `setstate' functions are those from BSD Unices. > The `rand' and `srand' functions are required by the ANSI standard. > We provide both interfaces to the same random number generator. */ > /* Return a random long integer between 0 and 2^31-1 inclusive. */ So I think we can simply drop the distinction between the two functions and use rand and srand everywhere, hence solving the compilation error with gcc on pip install on Fedora
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On gcc 15, using -std=c99 (as set in setup.py, for NEM c source compilation), the random function is not defined. (at least this is the case on Fedora 43).
According to stdlib.h file, both rand and random function uses the same generator in glibc implementation.
So I think we can simply drop the distinction between the two functions and use rand and srand everywhere, hence solving the compilation error with gcc on pip install on Fedora.