Use add_color_level() conditionally #1592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
previously approved these changes
Feb 4, 2025
|
Thanks for the PR, this is missing a DCO, you can add this with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1592 +/- ##
========================================
- Coverage 56.0% 55.8% -0.3%
========================================
Files 170 170
Lines 13307 13369 +62
========================================
+ Hits 7458 7461 +3
- Misses 5849 5908 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cidlik
force-pushed
the
add-color-level-issue
branch
from
2c6c3b8 to
36a898a
Compare
Emantor
force-pushed
the
add-color-level-issue
branch
from
0b5172b to
4d98bb2
Compare
|
Your name in the DCO matches, but the email adress does not. |
According to [1] add_color_level() is a method of ColoredLevelFormatter only. [1] https://github.com/pytest-dev/pytest/blob/main/src/_pytest/logging.py#L104 Change-Id: Iaa67c613b196b9cbbbc930d547edaa784d545130 Signed-off-by: Roman Kuznecov <[email protected]>
cidlik
force-pushed
the
add-color-level-issue
branch
from
4d98bb2 to
43b5325
Compare
Yeap, sorry, it's my bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to [1] add_color_level() is a method of ColoredLevelFormatter
only. The exception AttributeError is raised for other formatters.
[1] https://github.com/pytest-dev/pytest/blob/main/src/_pytest/logging.py#L104
Checklist