contrib/sync-places: filter tags during creation #1651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1651 +/- ##
======================================
Coverage 55.8% 55.8%
======================================
Files 170 170
Lines 13388 13388
======================================
Hits 7472 7472
Misses 5916 5916
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In older versions of python, when iterating over a dictionary, a copy would be created allowing us to modify the dictionary while we're iterating over it. Newer versions however do not make this copy and now raise runtime errors when the keys change while we're iterating over them. Transform the key/values during creation of the 'tags' dictionary to avoid having to delete keys afterwards. Signed-off-by: Bryan Brattlof <[email protected]>
bryanbrattlof
force-pushed
the
sync-places-fix
branch
from
fc84dc0 to
b8dd4c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In older versions of python, when iterating over a dictionary, a copy would be created allowing us to modify the dictionary while we're iterating over it. Newer versions however do not make this copy and now raise runtime errors when the keys change while we're iterating over them.
Transform the key/values during creation of the 'tags' dictionary to avoid having to delete keys afterwards.
Checklist
Fixes #1312