ENH: return permutation vectors in compute_selecitivity_continuous #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmagnuski
force-pushed
the
perm_vecs_sel_cnt
branch
from
4106a2e to
83f615e
Compare
Collaborator
Author
|
This will have to wait for a next release of borsar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when the selectivity criteria are multi-conditional: for example more than one statistical test or statistical test + other conditions (like increase in firing rate for the preferred stimulus/condition). Because
pylabianca.selectivity.compute_selectivity_continuous()handles permutations internally it needs to expose the permutation vectors so that the custom criteria can be computed on the exact same permuted data.