Skip to content

Conversation

@mmagnuski
Copy link
Collaborator

@mmagnuski mmagnuski commented Dec 15, 2025

  • fix pylabianca.utils.assign_session_coord() when the passed xarray.DataArray has the 'cell' dimension in .coords but not in .dims (for example after doing arr.isel(cell=2))
  • make sure pln.aggregate() works when the zscore is passed as an xarray
  • FIX: dict_to_xarray would fail for dicts with xarrays without trial dimension

TODOs:

  • make sure the is test for the zscore as xarray in aggregate
  • check what happens now (vs what should happen) when aggregate is given a dictionary and an xarray zscore (should get two dictionaries most likely).
  • add deprecations to xarray_to_dict and dict_to_xarray for ses_name -> ses_coord
  • add changes to whatsnew

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

@@          Coverage Diff          @@
##            main     #61   +/-   ##
=====================================
  Coverage   77.9%   78.0%           
=====================================
  Files         19      19           
  Lines       3912    3922   +10     
=====================================
+ Hits        3050    3061   +11     
+ Misses       862     861    -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants