Skip to content

chore: prepare the repository for public release - #3

Merged
kyujin-cho merged 1 commit into
mainfrom
chore/prepare-for-public-release
Jul 15, 2026
Merged

chore: prepare the repository for public release#3
kyujin-cho merged 1 commit into
mainfrom
chore/prepare-for-public-release

Conversation

@Yaminyam

Copy link
Copy Markdown
Member

Cleanup ahead of making this repository public (BA-6864). Nothing here changes plugin behaviour on the request path — it removes dead template cruft, fixes broken Makefile paths, adds the missing license, and drops a stray debug print.

Why now

The core installer currently fetches this plugin's release tarball and, because this repo is private, has to fall back to gh release download. That fallback does not work for external users, which blocks the traefik frontend rollout. Making the repo public removes that fragility — so let's make sure it is presentable first.

Changes

Add LICENSE (LGPL-3.0) — the repo had none. Matches lablup/backend.ai.

Remove docker-compose.yml — it is pure leftover from the upstream template this repo was bootstrapped from, and has never worked here:

  • declares the plugin under the unrelated third-party module path github.com/nihaopaul/traefik-rust-wasm-plugin
  • mounts pkg/traefik-auth.wasm, a file the build never produces (make release emits pkg/backend.ai/appproxy-traefik-plugin/plugin.wasm)
  • configures the middleware with cf_token / cf_org / cf_domain, none of which this plugin accepts — it takes circuit, jwt_secret, permit_hash_secret, permit_cookie_name

Rather than invent an untested dev harness, it is removed. Happy to add a real one in a follow-up if it is wanted.

Makefile — drop the targets that only existed to drive that compose file (docker; and http, which curled the deleted whoami /foo route), and fix two broken paths:

  • debug pointed at the nonexistent pkg/traefik-auth.wasm → now the real artifact
  • cargo pointed at a nonexistent libs/ directory → now traefik_wasm_api/

go/plugin.go — remove a leftover debug print that dumped the whole plugin config to stderr on every middleware instantiation (once per circuit):

os.Stderr.WriteString(fmt.Sprintf("########## New, config: %+v $$$$$$$$$$\n", config))

Verification

  • go vet ./... and go build ./... pass
  • cargo build --target wasm32-wasip1 --release succeeds
  • make release still emits exactly the layout traefik loads from plugins-local/src/:
    backend.ai/appproxy-traefik-plugin/{plugin.wasm,.traefik.yml}
    backend.ai/appproxy-traefik-plugin-go/{plugin.go,go.mod,go.sum,.traefik.yml}
    
    which matches what is deployed today.

Pre-public audit (for the reviewer)

I scanned the full git history before proposing this:

  • no hardcoded secrets (only doc placeholders like "base64-encoded-secret")
  • no internal hostnames / infrastructure references

🤖 Generated with Claude Code

Clean up leftovers from the upstream template this repo was bootstrapped
from, and add the missing license, so the repository is presentable once
it is made public.

- Add LICENSE (LGPL-3.0), matching lablup/backend.ai.
- Remove docker-compose.yml. It was pure template cruft and never worked
  here: it declared the plugin under the unrelated third-party module path
  `github.com/nihaopaul/traefik-rust-wasm-plugin`, mounted `pkg/traefik-auth.wasm`
  (a file the build never produces -- `make release` emits
  `pkg/backend.ai/appproxy-traefik-plugin/plugin.wasm`), and configured the
  middleware with `cf_token` / `cf_org` / `cf_domain`, none of which this
  plugin accepts (it takes `circuit`, `jwt_secret`, `permit_hash_secret`,
  `permit_cookie_name`).
- Drop the Makefile targets that only existed to drive that compose file
  (`docker`, and `http`, which curled the deleted whoami `/foo` route), and
  fix two broken paths: `debug` pointed at the nonexistent
  `pkg/traefik-auth.wasm`, and `cargo` at a nonexistent `libs/` directory.
- Remove a leftover debug print in go/plugin.go that dumped the plugin
  config to stderr on every middleware instantiation (i.e. once per circuit).

Verified: `go vet` / `go build` pass, `cargo build --target wasm32-wasip1
--release` succeeds, and `make release` still emits the exact layout traefik
loads from `plugins-local/src/` (`backend.ai/appproxy-traefik-plugin/` +
`backend.ai/appproxy-traefik-plugin-go/`).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Yaminyam
Yaminyam requested a review from kyujin-cho July 14, 2026 00:16
@kyujin-cho
kyujin-cho merged commit f5da69c into main Jul 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants