chore: prepare the repository for public release - #3
Merged
Conversation
Clean up leftovers from the upstream template this repo was bootstrapped from, and add the missing license, so the repository is presentable once it is made public. - Add LICENSE (LGPL-3.0), matching lablup/backend.ai. - Remove docker-compose.yml. It was pure template cruft and never worked here: it declared the plugin under the unrelated third-party module path `github.com/nihaopaul/traefik-rust-wasm-plugin`, mounted `pkg/traefik-auth.wasm` (a file the build never produces -- `make release` emits `pkg/backend.ai/appproxy-traefik-plugin/plugin.wasm`), and configured the middleware with `cf_token` / `cf_org` / `cf_domain`, none of which this plugin accepts (it takes `circuit`, `jwt_secret`, `permit_hash_secret`, `permit_cookie_name`). - Drop the Makefile targets that only existed to drive that compose file (`docker`, and `http`, which curled the deleted whoami `/foo` route), and fix two broken paths: `debug` pointed at the nonexistent `pkg/traefik-auth.wasm`, and `cargo` at a nonexistent `libs/` directory. - Remove a leftover debug print in go/plugin.go that dumped the plugin config to stderr on every middleware instantiation (i.e. once per circuit). Verified: `go vet` / `go build` pass, `cargo build --target wasm32-wasip1 --release` succeeds, and `make release` still emits the exact layout traefik loads from `plugins-local/src/` (`backend.ai/appproxy-traefik-plugin/` + `backend.ai/appproxy-traefik-plugin-go/`). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup ahead of making this repository public (BA-6864). Nothing here changes plugin behaviour on the request path — it removes dead template cruft, fixes broken Makefile paths, adds the missing license, and drops a stray debug print.
Why now
The core installer currently fetches this plugin's release tarball and, because this repo is private, has to fall back to
gh release download. That fallback does not work for external users, which blocks the traefik frontend rollout. Making the repo public removes that fragility — so let's make sure it is presentable first.Changes
Add
LICENSE(LGPL-3.0) — the repo had none. Matcheslablup/backend.ai.Remove
docker-compose.yml— it is pure leftover from the upstream template this repo was bootstrapped from, and has never worked here:github.com/nihaopaul/traefik-rust-wasm-pluginpkg/traefik-auth.wasm, a file the build never produces (make releaseemitspkg/backend.ai/appproxy-traefik-plugin/plugin.wasm)cf_token/cf_org/cf_domain, none of which this plugin accepts — it takescircuit,jwt_secret,permit_hash_secret,permit_cookie_nameRather than invent an untested dev harness, it is removed. Happy to add a real one in a follow-up if it is wanted.
Makefile — drop the targets that only existed to drive that compose file (
docker; andhttp, which curled the deleted whoami/fooroute), and fix two broken paths:debugpointed at the nonexistentpkg/traefik-auth.wasm→ now the real artifactcargopointed at a nonexistentlibs/directory → nowtraefik_wasm_api/go/plugin.go— remove a leftover debug print that dumped the whole plugin config to stderr on every middleware instantiation (once per circuit):Verification
go vet ./...andgo build ./...passcargo build --target wasm32-wasip1 --releasesucceedsmake releasestill emits exactly the layout traefik loads fromplugins-local/src/:Pre-public audit (for the reviewer)
I scanned the full git history before proposing this:
"base64-encoded-secret")🤖 Generated with Claude Code