fix(FR-750): improve resource slot display in SessionSlotCell component#3438
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
yomybaby
changed the title
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.32% | 408/9446 |
| 🔴 | Branches | 3.69% | 240/6512 |
| 🔴 | Functions | 2.62% | 79/3016 |
| 🔴 | Lines | 4.26% | 393/9235 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from b548693
Merge activity
|
…nt (#3438) Resolves #3437 (FR-750) # Enhance Resource Slot Display in Session Slot Cell This PR improves the display of resource slots in the SessionSlotCell component: 1. Replaces `deviceMetadata` with `mergedResourceSlots` from the `useResourceSlotsDetails` hook 2. Enhances memory display with fixed decimal precision (3 digits) 3. Filters out accelerators with zero or invalid values 4. Uses `display_unit` from resource slots data instead of `human_readable_name` 5. Modifies the `useResourceSlotsDetails` hook to: - Accept empty resource group name to fetch all resource slots - Handle URL parameter construction more robustly - Return an empty object instead of undefined when manager version is incompatible Before 1: New accelerator type and 0 accelerator type  After 1: New accelerator type and 0 accelerator type  Before 2:  After 2: 
graphite-app
Bot
force-pushed
the
fix/session-slot-cell-format
branch
from
ce2e8ff to
b548693
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3437 (FR-750)
Enhance Resource Slot Display in Session Slot Cell
This PR improves the display of resource slots in the SessionSlotCell component:
deviceMetadatawithmergedResourceSlotsfrom theuseResourceSlotsDetailshookdisplay_unitfrom resource slots data instead ofhuman_readable_nameuseResourceSlotsDetailshook to:Before 1: New accelerator type and 0 accelerator type
After 1: New accelerator type and 0 accelerator type
Before 2:
After 2: