fix(FR-764): increase agent select page size and add search functionality#3455
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.23% (-0% 🔻) |
408/9648 |
| 🔴 | Branches | 3.6% (-0% 🔻) |
240/6663 |
| 🔴 | Functions | 2.57% (-0% 🔻) |
79/3078 |
| 🔴 | Lines | 4.17% (-0% 🔻) |
393/9429 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / AgentSelect.tsx |
5% (-1.25% 🔻) |
0% | 0% | 5% (-1.25% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from a9af38b
yomybaby
changed the title
yomybaby
force-pushed
the
fix/agent-select-options
branch
from
8e74353 to
a42d99d
Compare
agatha197
requested changes
Apr 9, 2025
Contributor
agatha197
left a comment
agatha197
left a comment
There was a problem hiding this comment.
When I search 'auto', it works.
But it doesn't work when I search 'i-Mac'.
Can you check again?
yomybaby
force-pushed
the
fix/agent-select-options
branch
from
a42d99d to
90a1791
Compare
Member
Author
|
The search function works properly. However, the constant appearance of "Auto Select" is confusing. It has been modified to display "Auto Select" based on the search keywords. Please review again. |
Merge activity
|
…lity (#3455) Resolves #3454 (FR-764) # Add search functionality to AgentSelect component This PR enhances the AgentSelect component by adding search functionality that allows users to filter agents by ID. The implementation: - Adds a search box to the agent selection dropdown - Implements search filtering using the `ilike` operator to match agent IDs - Uses React's `useTransition` hook to handle search state updates without blocking the UI - Increases the default page size from 20 to 50 agents - Disables the default filtering option in favor of the custom search implementation
graphite-app
Bot
force-pushed
the
fix/agent-select-options
branch
from
90a1791 to
a9af38b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3454 (FR-764)
Add search functionality to AgentSelect component
This PR enhances the AgentSelect component by adding search functionality that allows users to filter agents by ID. The implementation:
ilikeoperator to match agent IDsuseTransitionhook to handle search state updates without blocking the UI