feat(FR-740): Create modal for accepting/rejecting invitations by agatha197 · Pull Request #3465 · lablup/backend.ai-webui

agatha197 · 2025-04-07T08:40:54Z

Add Folder Invitation Response Modal

This PR adds a new modal component that allows users to respond to folder invitations. When users click on the "Invited Folders" section in the Storage Status Panel, they can now see a list of pending invitations with options to accept or decline each invitation.

The implementation includes:

New FolderInvitationResponseModal component that displays invitation details
Integration with the existing useVFolderInvitations hook
Enhanced VFolderPermissionCell to support both fragment and direct permission props
Added "From" translation key across all language files
Updated the Storage Status Panel to make the invitation count clickable

Checklist:

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

agatha197 · 2025-04-07T08:41:11Z

feat(FR-740): Create modal for accepting/rejecting invitations #3465 👈 (View in Graphite)
feat[FR-738]: add folder invitation badge #3440
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

lizable

Here are minor requests for modal popup.

How about leave the invitation modal When It comes to have multiple invitations from users, It may distracts every time user clicks add on each invitation from modal. Maybe we can leave the modal as is after clicking add/decline in modal popup.

How about adding Accept all / Decline all options?
it would be great to have accept all/decline all button when user got multiple invitations from user(s). Let's handle this issue as a new feature.

agatha197 · 2025-05-26T04:02:56Z

I'll add second one after mutation is added.

ironAiken2

I think this PR has merge conflicts. Can you check them?

lizable

It's reasonable to keep showing invited folder list modal when some invitations are left, but after accept/rejecting all of invitation, I don't think we need to show the modal. For now, It keeps blinking.

agatha197 · 2025-05-27T03:37:21Z

Resolved.

lizable

Works fine. LGTM.

ironAiken2

LGTM

graphite-app · 2025-05-27T07:11:23Z

Merge activity

May 27, 7:11 AM UTC: agatha197 added this pull request to the Graphite merge queue.
May 27, 7:14 AM UTC: Merged by the Graphite merge queue.

Resolves #3535 ([FR-740](https://lablup.atlassian.net/browse/FR-740)) # Add Folder Invitation Response Modal This PR adds a new modal component that allows users to respond to folder invitations. When users click on the "Invited Folders" section in the Storage Status Panel, they can now see a list of pending invitations with options to accept or decline each invitation. The implementation includes: - New `FolderInvitationResponseModal` component that displays invitation details - Integration with the existing `useVFolderInvitations` hook - Enhanced `VFolderPermissionCell` to support both fragment and direct permission props - Added "From" translation key across all language files - Updated the Storage Status Panel to make the invitation count clickable ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/93e5999e-a32f-4507-a836-8d935f9b3893.png) **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-740]: https://lablup.atlassian.net/browse/FR-740?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

agatha197 mentioned this pull request Apr 7, 2025

feat[FR-738]: add folder invitation badge #3440

Merged

6 tasks

github-actions Bot assigned agatha197 Apr 7, 2025

github-actions Bot added the size:L 100~500 LoC label Apr 7, 2025

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from fca0bfd to f357591 Compare April 10, 2025 03:59

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from f9a6362 to 3eb690e Compare April 10, 2025 03:59

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from f357591 to 10643d7 Compare April 10, 2025 04:00

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 3eb690e to 55ffd55 Compare April 10, 2025 04:00

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from 10643d7 to e78f39b Compare April 10, 2025 06:33

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch 2 times, most recently from 4320752 to 8fa6111 Compare April 10, 2025 07:34

ironAiken2 force-pushed the feat_FR-738_/invitation-badge branch from e78f39b to eb2fb03 Compare April 18, 2025 03:30

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from eb2fb03 to 53f59da Compare April 21, 2025 01:56

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 8fa6111 to 018d945 Compare April 21, 2025 01:56

github-actions Bot added area:ux UI / UX issue. area:i18n Localization labels Apr 21, 2025

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 018d945 to 85526cc Compare April 21, 2025 03:07

agatha197 marked this pull request as ready for review April 21, 2025 03:08

agatha197 requested review from ironAiken2, lizable, ragingwind and yomybaby April 21, 2025 03:08

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 85526cc to 4aaac5c Compare April 21, 2025 03:09

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from 53f59da to ce64713 Compare April 21, 2025 03:09

ragingwind reviewed Apr 21, 2025

View reviewed changes

Comment thread react/src/components/FolderInvitationResponseModal.tsx Outdated

ragingwind reviewed Apr 21, 2025

View reviewed changes

Comment thread react/src/components/VFolderPermissionCell.tsx Outdated

ragingwind reviewed Apr 21, 2025

View reviewed changes

Comment thread react/src/components/VFolderPermissionCell.tsx Outdated

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 4aaac5c to 701524f Compare April 21, 2025 10:24

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from ce64713 to 193e25f Compare April 21, 2025 10:24

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 701524f to 540b74c Compare April 21, 2025 10:42

lizable requested changes May 23, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from a4e708f to 4de227f Compare May 26, 2025 04:01

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from 3e9eecd to 3e532cf Compare May 26, 2025 04:01

agatha197 requested review from lizable and ragingwind May 26, 2025 04:01

ironAiken2 requested changes May 26, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from 3e532cf to 513539a Compare May 26, 2025 08:23

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 4de227f to 2c66ded Compare May 26, 2025 08:23

agatha197 requested a review from ironAiken2 May 27, 2025 01:20

lizable requested changes May 27, 2025

View reviewed changes

lizable force-pushed the feat_FR-738_/invitation-badge branch from 513539a to 3a64999 Compare May 27, 2025 02:42

lizable force-pushed the feat_FR-740_/invitation-response-modal branch from 2c66ded to 765e203 Compare May 27, 2025 02:42

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 765e203 to 2f37a13 Compare May 27, 2025 03:27

agatha197 force-pushed the feat_FR-738_/invitation-badge branch from 3a64999 to 513539a Compare May 27, 2025 03:27

agatha197 requested a review from lizable May 27, 2025 03:28

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 2f37a13 to d1b1201 Compare May 27, 2025 03:36

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from d1b1201 to 70edc5a Compare May 27, 2025 06:51

lizable approved these changes May 27, 2025

View reviewed changes

ironAiken2 approved these changes May 27, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-740_/invitation-response-modal branch from 70edc5a to cb18cb4 Compare May 27, 2025 07:05

graphite-app Bot force-pushed the feat_FR-738_/invitation-badge branch from 513539a to 2bd604d Compare May 27, 2025 07:12

graphite-app Bot force-pushed the feat_FR-740_/invitation-response-modal branch from cb18cb4 to e010cfd Compare May 27, 2025 07:12

Base automatically changed from feat_FR-738_/invitation-badge to main May 27, 2025 07:14

graphite-app Bot merged commit e010cfd into main May 27, 2025
4 checks passed

graphite-app Bot deleted the feat_FR-740_/invitation-response-modal branch May 27, 2025 07:14

github-pages Bot temporarily deployed to github-pages May 27, 2025 07:15 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(FR-740): Create modal for accepting/rejecting invitations#3465

feat(FR-740): Create modal for accepting/rejecting invitations#3465
graphite-app[bot] merged 1 commit into
mainfrom
feat_FR-740_/invitation-response-modal

agatha197 commented Apr 7, 2025 •

edited by atlassian Bot

Loading

Uh oh!

agatha197 commented Apr 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lizable left a comment

Uh oh!

agatha197 commented May 26, 2025

Uh oh!

ironAiken2 left a comment

Uh oh!

lizable left a comment

Uh oh!

agatha197 commented May 27, 2025

Uh oh!

lizable left a comment

Uh oh!

ironAiken2 left a comment

Uh oh!

graphite-app Bot commented May 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

agatha197 commented Apr 7, 2025 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Add Folder Invitation Response Modal

Uh oh!

agatha197 commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lizable left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 commented May 26, 2025

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

lizable left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 commented May 27, 2025

Uh oh!

lizable left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app Bot commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

agatha197 commented Apr 7, 2025 •

edited by atlassian Bot

Loading

agatha197 commented Apr 7, 2025 •

edited

Loading

graphite-app Bot commented May 27, 2025 •

edited

Loading