e2e(FR-763): add FolderCreationModal class for testing#3467
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
nowgnuesLee
changed the title
nowgnuesLee
changed the title
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.14% | 409/9874 |
| 🔴 | Branches | 3.52% | 240/6819 |
| 🔴 | Functions | 2.52% | 79/3140 |
| 🔴 | Lines | 4.08% | 394/9662 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 3974edd
yomybaby
requested changes
Apr 11, 2025
nowgnuesLee
force-pushed
the
feat/add-folder-creation-modal-class
branch
2 times, most recently
from
fa963dd to
b1c08e3
Compare
yomybaby
force-pushed
the
feat/add-folder-creation-modal-class
branch
2 times, most recently
from
f6e0bc9 to
2ce9524
Compare
Merge activity
|
resolves #3453 (FR-763) This PR adds `FolderCreationModal` class and tests to test this class. * restructure util functions. * add `FolderCreationModal` class. * add `vFolder Creation` test cases. **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
Bot
force-pushed
the
feat/add-folder-creation-modal-class
branch
from
2ce9524 to
3974edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3453 (FR-763)
This PR adds
FolderCreationModalclass and tests to test this class.FolderCreationModalclass.vFolder Creationtest cases.Checklist: (if applicable)