fix(FR-791): Add drop container to sender#3469
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
ragingwind
changed the title
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.23% | 408/9641 |
| 🔴 | Branches | 3.61% | 240/6657 |
| 🔴 | Functions | 2.57% | 79/3077 |
| 🔴 | Lines | 4.17% | 393/9425 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 0e35b58
yomybaby
requested changes
Apr 9, 2025
Member
yomybaby
left a comment
yomybaby
left a comment
There was a problem hiding this comment.
How about making the entire chat card a drop zone instead of just the sender part?
Merge activity
|
resolves #3468 (FR-791) # Fix ChatInput component's drop container reference This PR fixes an issue in the `ChatInput` component by correctly passing the `dropContainerRef` to both the parent `Flex` component and the `ChatSender` component. Previously, the reference was created but not properly attached to the container element, which could affect file drop functionality. **Changes:** - Renamed `cardRef` to `dropContainerRef` for better semantic clarity - Added the ref to the parent `Flex` component - Passed the same ref to the `ChatSender` component
graphite-app
Bot
force-pushed
the
fix/drag-drop
branch
from
5edaf23 to
0e35b58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3468 (FR-791)
Fix ChatInput component's drop container reference
This PR fixes an issue in the
ChatInputcomponent by correctly passing thedropContainerRefto both the parentFlexcomponent and theChatSendercomponent. Previously, the reference was created but not properly attached to the container element, which could affect file drop functionality.Changes:
cardReftodropContainerReffor better semantic clarityFlexcomponentChatSendercomponent