Skip to content

fix(FR-801): update reset button to hide cloneable toggle#3477

Merged
graphite-app[bot] merged 1 commit into
mainfrom
fix/update-reset-button-to-hide-cloneable
Apr 10, 2025
Merged

fix(FR-801): update reset button to hide cloneable toggle#3477
graphite-app[bot] merged 1 commit into
mainfrom
fix/update-reset-button-to-hide-cloneable

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 10, 2025

resolves #3475 (FR-801)
Reset button can hide cloneable toggle button

changes

  • Change setFieldsValue to resetFields in the reset button

CleanShot 2025-04-10 at 12 46 27

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.25% 408/9590
🔴 Branches 3.63% 240/6607
🔴 Functions 2.59% 79/3056
🔴 Lines 4.19% 393/9374

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 6bd0644

@nowgnuesLee nowgnuesLee marked this pull request as ready for review April 10, 2025 03:45
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 10, 2025

Merge activity

resolves #3475 (FR-801)
Reset button can hide cloneable toggle button

**changes**
* Change `setFieldsValue` to `resetFields` in the reset button

![CleanShot 2025-04-10 at 12 46 27](https://github.com/user-attachments/assets/e6c73c4d-6bea-4414-86b0-21992a7d9228)

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app Bot force-pushed the fix/update-reset-button-to-hide-cloneable branch from fa05c34 to 6bd0644 Compare April 10, 2025 03:54
@graphite-app graphite-app Bot merged commit 6bd0644 into main Apr 10, 2025
7 checks passed
@graphite-app graphite-app Bot deleted the fix/update-reset-button-to-hide-cloneable branch April 10, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reset button doesn't hide cloneable toggle on folder creation modal

2 participants