hotfix(FR-802): Disable Delete Button for Users with 'User' Role#3479
Merged
graphite-app[bot] merged 1 commit intoApr 11, 2025
Merged
Conversation
github-actions
Bot
added
area:ux
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.22% | 408/9675 |
| 🔴 | Branches | 3.6% | 240/6672 |
| 🔴 | Functions | 2.56% | 79/3089 |
| 🔴 | Lines | 4.15% | 393/9462 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 7bed42c
yomybaby
requested changes
Apr 11, 2025
Member
yomybaby
left a comment
yomybaby
left a comment
There was a problem hiding this comment.
Let's improve the tooltip message.
agatha197
force-pushed
the
hotfix_FR-802_/disable-delete-button-for-user-role
branch
from
59ba5fe to
e9ff3b9
Compare
Merge activity
|
Resolves #3476 ([FR-802](https://lablup.atlassian.net/browse/FR-802)) # Disable "Move to Trash" button for users on group-owned folders This PR prevents users from moving project folders to trash by disabling the "Move to Trash" button for group-owned folders when the current user has a 'user' role. The button is visually disabled and shows a tooltip explaining that users cannot delete project folders. - project folder with 'user' role  - general folder  **Checklist:** - [x] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-802]: https://lablup.atlassian.net/browse/FR-802?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
Bot
force-pushed
the
hotfix_FR-802_/disable-delete-button-for-user-role
branch
from
e9ff3b9 to
7bed42c
Compare
graphite-app
Bot
deleted the
hotfix_FR-802_/disable-delete-button-for-user-role
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3476 (FR-802)
Disable "Move to Trash" button for users on group-owned folders
This PR prevents users from moving project folders to trash by disabling the "Move to Trash" button for group-owned folders when the current user has a 'user' role. The button is visually disabled and shows a tooltip explaining that users cannot delete project folders.
project folder with 'user' role
general folder
Checklist: