feat(FR-777): use resource limit of resource group#3480
Merged
graphite-app[bot] merged 1 commit intoApr 11, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.21% (-0% 🔻) |
408/9682 |
| 🔴 | Branches | 3.59% (-0% 🔻) |
240/6677 |
| 🔴 | Functions | 2.56% (-0% 🔻) |
79/3090 |
| 🔴 | Lines | 4.15% (-0% 🔻) |
393/9470 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / useResourceLimitAndRemaining.tsx |
18.75% (-1.25% 🔻) |
4.92% (-0.44% 🔻) |
6.25% (-0.42% 🔻) |
19.15% (-1.31% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 4c1d325
yomybaby
force-pushed
the
feature/resource-limit-per-resource-group
branch
2 times, most recently
from
e45d290 to
1507691
Compare
Merge activity
|
Resolves #3463 (FR-777) To conduct the test, you must use the environment at lablup/backend.ai#4108. There is a test server for this PR, and related details can be found at the following [link](https://teams.microsoft.com/l/message/19:acd1be4236b94664b814f4d4e5c84da6@thread.skype/1744025901127?tenantId=13c6a44d-9b52-4b9e-aa34-0513ee7131f2&groupId=74ae2c4d-ec4d-4fdf-b2c2-f5041d1e8631&parentMessageId=1744011801142&teamName=devops&channelName=JIRA%20Issue%20Notification&createdTime=1744025901127). This PR adds several new GraphQL types and queries: 1. (Key change) **Enhanced resource limit calculation to consider scaling group resource limits** 2. Update schema for `resource_slot_limit` field to the ScalingGroup type to expose resource limits 3. Fixed number formatting in DynamicUnitInputNumberWithSlider to prevent trailing zeros
graphite-app
Bot
force-pushed
the
feature/resource-limit-per-resource-group
branch
from
1507691 to
4c1d325
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3463 (FR-777)
To conduct the test, you must use the environment at lablup/backend.ai#4108. There is a test server for this PR, and related details can be found at the following link.
This PR adds several new GraphQL types and queries:
resource_slot_limitfield to the ScalingGroup type to expose resource limits