Skip to content

style(FR-816): Improve Start page grid size for XXL screen#3483

Merged
graphite-app[bot] merged 1 commit into
mainfrom
fix/start-page-grid-style
Apr 11, 2025
Merged

style(FR-816): Improve Start page grid size for XXL screen#3483
graphite-app[bot] merged 1 commit into
mainfrom
fix/start-page-grid-style

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented Apr 11, 2025

Resolves #3482 (FR-816)

This PR adds support for the XXL breakpoint in the responsive design system. It includes:

  1. Added screenXLMax, screenXXLMin, and screenXXL values to both light and dark themes in theme.json
  2. Added xxl={4} column sizing to the card layout in StartPage, allowing for better use of screen space on larger displays
  3. Removed the AnnouncementAlert component from the summary page

These changes improve the UI layout on larger screens by allowing more cards to be displayed in a row when sufficient screen space is available.

@github-actions github-actions Bot added the size:S 10~30 LoC label Apr 11, 2025
Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby changed the title style: Improve Start page grid size for XXL screen style(FR-816): Improve Start page grid size for XXL screen Apr 11, 2025
@yomybaby yomybaby force-pushed the fix/start-page-grid-style branch from 06e7cfa to 8fc5003 Compare April 11, 2025 06:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 11, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.22% 408/9674
🔴 Branches 3.6% 240/6672
🔴 Functions 2.56% 79/3089
🔴 Lines 4.15% 393/9462

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e8f798c

@yomybaby yomybaby force-pushed the fix/start-page-grid-style branch from 8fc5003 to 188139b Compare April 11, 2025 06:52
@yomybaby yomybaby marked this pull request as ready for review April 11, 2025 06:52
@yomybaby yomybaby requested a review from nowgnuesLee April 11, 2025 07:01
@yomybaby yomybaby force-pushed the fix/start-page-grid-style branch from 188139b to 246bff5 Compare April 11, 2025 07:07
@github-actions github-actions Bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Apr 11, 2025
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 11, 2025

Merge activity

Resolves #3482 (FR-816)

This PR adds support for the XXL breakpoint in the responsive design system. It includes:

1. Added `screenXLMax`, `screenXXLMin`, and `screenXXL` values to both light and dark themes in `theme.json`
2. Added `xxl={4}` column sizing to the card layout in StartPage, allowing for better use of screen space on larger displays
3. Removed the `AnnouncementAlert` component from the summary page

These changes improve the UI layout on larger screens by allowing more cards to be displayed in a row when sufficient screen space is available.
@graphite-app graphite-app Bot force-pushed the fix/start-page-grid-style branch from 246bff5 to e8f798c Compare April 11, 2025 07:09
@graphite-app graphite-app Bot merged commit e8f798c into main Apr 11, 2025
6 checks passed
@graphite-app graphite-app Bot deleted the fix/start-page-grid-style branch April 11, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Start page grid style

2 participants