fix(FR-823): log message scroll bar is too wide when logs are empty.#3487
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.21% | 408/9683 |
| 🔴 | Branches | 3.59% | 240/6679 |
| 🔴 | Functions | 2.56% | 79/3091 |
| 🔴 | Lines | 4.15% | 393/9471 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 7dbb479
Merge activity
|
…3487) Resolves #3486 ([FR-823](https://lablup.atlassian.net/browse/FR-823)) # Conditionally set table scroll height in ErrorLogList This PR modifies the `ErrorLogList` component to conditionally set the vertical scroll height. When there are no error logs to display (filtered log data with `isError` is empty), the vertical scroll height is set to `undefined` instead of a fixed calculation. This prevents unnecessary scrollbars from appearing when there's no error data to scroll through. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-823]: https://lablup.atlassian.net/browse/FR-823?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
Bot
force-pushed
the
bugfix_FR-823_/scroll-bar-is-too-wide
branch
from
521466d to
7dbb479
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3486 (FR-823)
Conditionally set table scroll height in ErrorLogList
This PR modifies the
ErrorLogListcomponent to conditionally set the vertical scroll height. When there are no error logs to display (filtered log data withisErroris empty), the vertical scroll height is set toundefinedinstead of a fixed calculation. This prevents unnecessary scrollbars from appearing when there's no error data to scroll through.Checklist: