feat(FR-826): allow role setting when creating a new user#3491
Merged
graphite-app[bot] merged 1 commit intoApr 16, 2025
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.18% | 409/9790 |
| 🔴 | Branches | 3.54% | 240/6771 |
| 🔴 | Functions | 2.54% | 79/3112 |
| 🔴 | Lines | 4.11% | 394/9575 |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from c7132ce
Merge activity
|
Resolves #3490 ([FR-826](https://lablup.atlassian.net/browse/FR-826)) # Refactor form handling in FolderCreateModal and fix UserSettingModal role check This PR makes two improvements: 1. In `FolderCreateModal.tsx`, simplifies the mutation function by using the spread operator to pass form values instead of explicitly listing each field. 2. In `UserSettingModal.tsx`, fixes a potential bug by removing an unnecessary check for `user?.role` when determining whether to display the role selection dropdown. The condition now only depends on `currentUserRole` being defined and having appropriate permissions. **Checklist:** - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-826]: https://lablup.atlassian.net/browse/FR-826?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
Bot
force-pushed
the
feat_FR-826_/allow-role-setting-when-creating-users
branch
from
940eb0c to
c7132ce
Compare
graphite-app
Bot
deleted the
feat_FR-826_/allow-role-setting-when-creating-users
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3490 (FR-826)
Refactor form handling in FolderCreateModal and fix UserSettingModal role check
This PR makes two improvements:
In
FolderCreateModal.tsx, simplifies the mutation function by using the spread operator to pass form values instead of explicitly listing each field.In
UserSettingModal.tsx, fixes a potential bug by removing an unnecessary check foruser?.rolewhen determining whether to display the role selection dropdown. The condition now only depends oncurrentUserRolebeing defined and having appropriate permissions.Checklist: