feat(FR-783): Refresh with baseURL and token#3494
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
d588d38 to
a7578f6
Compare
cc6586d to
c01fd19
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.13% (-0.02% 🔻) |
409/9892 |
| 🔴 | Branches | 3.52% (-0.01% 🔻) |
240/6819 |
| 🔴 | Functions | 2.52% (-0.01% 🔻) |
79/3139 |
| 🔴 | Lines | 4.07% (-0.02% 🔻) |
394/9675 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / EndpointTokenSelect.tsx |
0% | 0% | 0% | 0% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ChatModel.tsx |
0% (-100% 🔻) |
0% (-100% 🔻) |
0% (-100% 🔻) |
0% (-100% 🔻) |
Test suite run success
124 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 82dfce5
c01fd19 to
72ebe44
Compare
|
Jimmy Moon seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Please sign CLA |
agatha197
left a comment
There was a problem hiding this comment.
Screen Recording 2025-04-22 at 10.46.51 AM.mov (uploaded via Graphite)
If the base path is empty, select the token and refresh, every input is initialized. But after refreshing again, Base Path has 'v1' automatically.
Screen Recording 2025-04-22 at 10.48.49 AM.mov (uploaded via Graphite)
If the base path is empty and refresh model information, the base path valid message disappears.
|
Fixed
|
5d0d46e to
82dfce5
Compare
5f8ae64 to
ac20500
Compare
ac20500 to
74e7e26
Compare
Merge activity
|
resolves 3466 (FR-783) Improved Custom Model Integration in Chat Component This PR enhances the custom model integration in the Chat component by: 1. Refactoring the model fetching logic to properly handle errors and display user-friendly messages 2. Adding a dedicated `ChatModelError` class to standardize error handling 3. Creating a new `EndpointTokenSelect` component to allow users to select from available endpoint tokens 4. Improving the `CustomModelForm` to better handle base URL and token inputs 5. Separating the model selection UI logic to only show when models are available 6. Implementing proper state management for base URL and token values
74e7e26 to
51835df
Compare


resolves 3466 (FR-783)
Improved Custom Model Integration in Chat Component
This PR enhances the custom model integration in the Chat component by:
ChatModelErrorclass to standardize error handlingEndpointTokenSelectcomponent to allow users to select from available endpoint tokensCustomModelFormto better handle base URL and token inputs