Skip to content

fix(FR-842): storage status mismatch with virtual nodes total count.#3510

Merged
graphite-app[bot] merged 1 commit into
mainfrom
fix_FR-842_/storage-status-total-mismatch
Apr 16, 2025
Merged

fix(FR-842): storage status mismatch with virtual nodes total count.#3510
graphite-app[bot] merged 1 commit into
mainfrom
fix_FR-842_/storage-status-total-mismatch

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 16, 2025

Resolves #3507 (FR-842)

Pass props to VFolderNodeListPage and add fetchKey to StorageStatusPanelCard

This PR passes the props to the root Flex component in VFolderNodeListPage and adds the fetchKey prop to the StorageStatusPanelCard component to ensure proper data fetching and refresh behavior.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.18% 409/9781
🔴 Branches 3.55% 240/6767
🔴 Functions 2.54% 79/3111
🔴 Lines 4.12% 394/9566

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 7b40af4

Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 16, 2025

Merge activity

…3510)

Resolves #3507 ([FR-842](https://lablup.atlassian.net/browse/FR-842))

### Pass props to VFolderNodeListPage and add fetchKey to StorageStatusPanelCard

This PR passes the props to the root Flex component in VFolderNodeListPage and adds the fetchKey prop to the StorageStatusPanelCard component to ensure proper data fetching and refresh behavior.

**Checklist:**

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after

[FR-842]: https://lablup.atlassian.net/browse/FR-842?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app Bot force-pushed the fix_FR-842_/storage-status-total-mismatch branch from 50e55c8 to 7b40af4 Compare April 16, 2025 01:51
@graphite-app graphite-app Bot merged commit 7b40af4 into main Apr 16, 2025
7 checks passed
@graphite-app graphite-app Bot deleted the fix_FR-842_/storage-status-total-mismatch branch April 16, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage status mismatch with virtual nodes total count.

2 participants