Skip to content

feat(FR-558): display human readable file size on folder explorer#3529

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat/human-readable-file-size
Apr 17, 2025
Merged

feat(FR-558): display human readable file size on folder explorer#3529
graphite-app[bot] merged 1 commit into
mainfrom
feat/human-readable-file-size

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 17, 2025

resolves #NNN (FR-558)
In this PR, make the file sizes that appear in folder explorer human-readable.

changes

  • make the file sizes that appear in folder explorer human-readable in the backend-ai-folder-exporer

CleanShot 2025-04-17 at 13.16.33@2x.png

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@github-actions github-actions Bot added the size:XS ~10 LoC label Apr 17, 2025
Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee marked this pull request as ready for review April 17, 2025 04:17
@nowgnuesLee nowgnuesLee force-pushed the feat/human-readable-file-size branch from 0ddbeab to 3b28383 Compare April 17, 2025 06:14
Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 17, 2025

Merge activity

)

resolves #NNN (FR-558)
In this PR, make the file sizes that appear in folder explorer human-readable.

**changes**
* make the file sizes that appear in folder explorer human-readable in the `backend-ai-folder-exporer`

![CleanShot 2025-04-17 at 13.16.33@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/xbCemO1RqqcSjEXCRK3p/d23e61e4-d58f-4fe4-b23a-be342516e14c.png)

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app Bot force-pushed the feat/human-readable-file-size branch from 3b28383 to 7628526 Compare April 17, 2025 10:28
@graphite-app graphite-app Bot merged commit 7628526 into main Apr 17, 2025
5 checks passed
@graphite-app graphite-app Bot deleted the feat/human-readable-file-size branch April 17, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants