Skip to content

feat(FR-559): display localized create date on the folder explorer#3532

Merged
graphite-app[bot] merged 1 commit into
mainfrom
feat/display-localized-create-date
Apr 22, 2025
Merged

feat(FR-559): display localized create date on the folder explorer#3532
graphite-app[bot] merged 1 commit into
mainfrom
feat/display-localized-create-date

Conversation

@nowgnuesLee
Copy link
Copy Markdown
Contributor

@nowgnuesLee nowgnuesLee commented Apr 17, 2025

resolves #NNN (FR-559)

Changes

  • Change to show localized create date using toLocaleString('en-US')

CleanShot 2025-04-17 at 16.51.48@2x.png

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nowgnuesLee nowgnuesLee marked this pull request as ready for review April 17, 2025 07:52
Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about displaying the date and time in the current country based on the user's browser language settings?

new Date(d).toLocaleString();

or using browser's language?

new Date(d).toLocaleString(navigator.language);

@nowgnuesLee nowgnuesLee force-pushed the feat/display-localized-create-date branch from fb0bf6d to e76ec78 Compare April 22, 2025 05:35
Copy link
Copy Markdown
Contributor Author

I changed it to use backendaioptions.get('selected_language').

@nowgnuesLee nowgnuesLee requested a review from agatha197 April 22, 2025 05:37
@yomybaby yomybaby self-requested a review April 22, 2025 07:03
Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nowgnuesLee nowgnuesLee requested a review from yomybaby April 22, 2025 07:11
Copy link
Copy Markdown
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented Apr 22, 2025

Merge activity

…3532)

resolves #NNN (FR-559)

**Changes**
* Change to show localized create date using `toLocaleString('en-US'`)

![CleanShot 2025-04-17 at 16.51.48@2x.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/xbCemO1RqqcSjEXCRK3p/bd8e2e62-e423-4ba8-862b-4a7f5582d0c2.png)

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app Bot force-pushed the feat/display-localized-create-date branch from e76ec78 to 1517ed6 Compare April 22, 2025 09:12
@graphite-app graphite-app Bot merged commit 1517ed6 into main Apr 22, 2025
5 checks passed
@graphite-app graphite-app Bot deleted the feat/display-localized-create-date branch April 22, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants