chore(FR-852): update validation message for folder name to allow only English letters#3539
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
Bot
added
area:ux
ironAiken2
requested changes
Apr 22, 2025
nowgnuesLee
force-pushed
the
chore/update-validation-message
branch
from
0b74e25 to
c30ccec
Compare
Contributor
|
영문 / 영문자 is widely used. |
agatha197
requested changes
Apr 22, 2025
agatha197
requested changes
Apr 24, 2025
Contributor
agatha197
left a comment
agatha197
left a comment
There was a problem hiding this comment.
Ah I confused. Never mind previous review.
In my opinion, when a dot (.) appears at the end of a sentence, it can be confusing whether it's allowed as part of the sentence or if it's intended as a period.
Contributor
Author
|
How about using ''? Like this '-', '_', '.' @agatha197 |
Contributor
good! |
nowgnuesLee
force-pushed
the
chore/update-validation-message
branch
2 times, most recently
from
99a9439 to
e89e423
Compare
yomybaby
force-pushed
the
chore/update-validation-message
branch
from
e89e423 to
6e62793
Compare
Merge activity
|
…y English letters (#3539) resolves #3521 (FR-852) **changes** * update validation message for folder name to allow only English letters * remove unused i18n key  **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
Bot
force-pushed
the
chore/update-validation-message
branch
from
6e62793 to
86c3285
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3521 (FR-852)
changes
Checklist: (if applicable)