chore(FR-831): update ResourcePresetSettingModal to display exact memory value#3540
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.62% | 481/10415 |
| 🔴 | Branches | 4.04% | 297/7350 |
| 🔴 | Functions | 2.74% | 90/3288 |
| 🔴 | Lines | 4.57% | 466/10195 |
Test suite run success
161 tests passing in 15 suites.
Report generated by 🧪jest coverage report action from fb95980
ironAiken2
requested changes
Apr 21, 2025
Contributor
ironAiken2
left a comment
ironAiken2
left a comment
There was a problem hiding this comment.
I have the same problem with shared memory, please fix it as well.
nowgnuesLee
force-pushed
the
chore/display-exact-memory-value
branch
from
7c66f49 to
4ed41d0
Compare
agatha197
reviewed
Apr 22, 2025
nowgnuesLee
force-pushed
the
chore/display-exact-memory-value
branch
from
4ed41d0 to
eb9ece5
Compare
yomybaby
requested changes
Apr 24, 2025
nowgnuesLee
force-pushed
the
chore/display-exact-memory-value
branch
2 times, most recently
from
3946b5e to
f05487e
Compare
github-actions
Bot
added
area:ux
nowgnuesLee
force-pushed
the
chore/display-exact-memory-value
branch
from
f05487e to
7b08859
Compare
nowgnuesLee
force-pushed
the
chore/display-exact-memory-value
branch
from
7b08859 to
dcd659f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines how memory values are displayed by removing hardcoded “(GB)” labels, introducing new unit-conversion helpers, and updating UI components to show exact or fallback values, especially handling zero correctly.
- Removed “(GB)” suffix from
SharedMemorylabels across all locales - Added
sizeUnitToDecimalSizeUnitandsizeUnitToBinarySizeUnithelper functions - Updated
ResourcePresetSettingModal,ResourcePresetList, andResourceNumberto use auto-scaling conversions and handle zero memory values properly
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/i18n/*.json | Removed the hardcoded “(GB)” suffix from SharedMemory translations |
| react/src/helper/index.tsx | Added DecimalSizeUnit/BinarySizeUnit types and mapping functions sizeUnitToDecimalSizeUnit & sizeUnitToBinarySizeUnit |
| react/src/components/ResourcePresetSettingModal.tsx | Switched memory conversion to use 'auto' when value ≠ 0 and fixed zero display |
| react/src/components/ResourcePresetList.tsx | Enhanced shared-memory column to show primary and fallback unit formats |
| react/src/components/ResourceNumber.tsx | Added secondary fallback display for non-zero memory with auto conversion |
Comments suppressed due to low confidence (1)
react/src/helper/index.tsx:188
- There are no unit tests covering
sizeUnitToDecimalSizeUnitandsizeUnitToBinarySizeUnit. Adding tests will ensure correct mappings and prevent regressions.
return unitMap[unit] || unit;
yomybaby
requested changes
May 20, 2025
nowgnuesLee
force-pushed
the
chore/display-exact-memory-value
branch
4 times, most recently
from
8c77c5d to
2026ac0
Compare
lizable
reviewed
May 28, 2025
yomybaby
force-pushed
the
chore/display-exact-memory-value
branch
from
2026ac0 to
f9dac72
Compare
yomybaby
approved these changes
May 28, 2025
Member
yomybaby
left a comment
yomybaby
left a comment
There was a problem hiding this comment.
LGTM but I made a refactoring PR for this PR changes.
Merge activity
|
…ory value (#3540) resolves #3498 (FR-831) **changes** * Changed `convertBinarySizeUnit()` for memory values to initialize to the correct exact via `auto` when using `convertBinarySizeUnit()`. * Changed `ResourcePresetList` to more accurately show the value for `shared memory`. * add `sizeUnitToDecimalSizeUnit` and `sizeUnitToBinarySizeUnit` function. * Fixed strange unit display in modal when memory value was set to 0 * add `NumberWithUnit` component   **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
graphite-app
Bot
force-pushed
the
chore/display-exact-memory-value
branch
from
f9dac72 to
fb95980
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3498 (FR-831)
changes
convertBinarySizeUnit()for memory values to initialize to the correct exact viaautowhen usingconvertBinarySizeUnit().ResourcePresetListto more accurately show the value forshared memory.sizeUnitToDecimalSizeUnitandsizeUnitToBinarySizeUnitfunction.NumberWithUnitcomponentChecklist: (if applicable)