fix(FR-2420): add missing identicon for mount folders in VFolderTable#6282
fix(FR-2420): add missing identicon for mount folders in VFolderTable#6282ironAiken2 wants to merge 1 commit intomainfrom
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.69% (+0.03% 🔼) |
1548/17816 |
| 🔴 | Branches | 7.55% (-0.05% 🔻) |
940/12458 |
| 🔴 | Functions | 5.64% (+0.03% 🔼) |
278/4929 |
| 🔴 | Lines | 8.37% (+0.02% 🔼) |
1452/17339 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / useModelCardMetadata.tsx |
0% | 0% | 0% | 0% |
Test suite run success
784 tests passing in 37 suites.
Report generated by 🧪jest coverage report action from 7dd708c
There was a problem hiding this comment.
Pull request overview
Adds a deterministic identicon next to each folder name in VFolderTable so mounted folders (and other rows shown by this table) have a visual identifier consistent with other vfolder UIs.
Changes:
- Import Dicebear
shapes/createAvatarintoVFolderTable. - Render an inline identicon
<img>next to the folder name link in the Name column.
|
All 3 Copilot feedback items have been addressed: the inline Dicebear
|
4367661 to
a01a1af
Compare
a01a1af to
7dd708c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
react/src/components/VFolderTable.tsx:347
- Avoid empty catch handlers:
internalForm.validateFields().catch(() => {})silently swallows validation errors and is flagged as a security/diagnostic concern in this codebase. If errors are intentionally ignored, make that explicit (e.g., returnundefined) or log at an appropriate level so unexpected failures aren’t hidden.
onChangeAliasMap?.(
_.mapValues(
_.pickBy(internalForm.getFieldsValue({ strict: false }), (v) => !!v), //remove empty
(v, k) => inputToAliasPath(k, v), // add alias base path
),
);
internalForm.validateFields().catch(() => {});

Resolves #6281(FR-2420)
Summary
VFolderTabledata source from REST API to Relay GraphQL (vfolder_nodesquery)VFolderNodeIdenticonfragment componentuseControllableState_deprecatedwith controlled props pattern forselectedRowKeysandaliasMapuseSuspenseTanQuerywithuseLazyLoadQueryfor consistent Relay-based data fetchingfilterOutNullAndUndefined,mergeFilterValues,toLocalIdutilities frombackend.ai-uiTest plan
🤖 Generated with Claude Code