Skip to content

fix(FR-2420): add missing identicon for mount folders in VFolderTable#6282

Open
ironAiken2 wants to merge 1 commit intomainfrom
04-01-fix_fr-2420_add_missing_identicon_for_mount_folders_in_vfoldertable
Open

fix(FR-2420): add missing identicon for mount folders in VFolderTable#6282
ironAiken2 wants to merge 1 commit intomainfrom
04-01-fix_fr-2420_add_missing_identicon_for_mount_folders_in_vfoldertable

Conversation

@ironAiken2
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 commented Apr 1, 2026

Resolves #6281(FR-2420)

Summary

  • Migrate VFolderTable data source from REST API to Relay GraphQL (vfolder_nodes query)
  • Add dicebear identicon (shapes avatar) next to folder names using the shared VFolderNodeIdenticon fragment component
  • Replace useControllableState_deprecated with controlled props pattern for selectedRowKeys and aliasMap
  • Replace useSuspenseTanQuery with useLazyLoadQuery for consistent Relay-based data fetching
  • Use filterOutNullAndUndefined, mergeFilterValues, toLocalId utilities from backend.ai-ui

Test plan

  • Open SessionLauncher form → verify VFolderTable shows folders with identicons
  • Open ModelService creation form → verify VFolderTable shows folders with identicons
  • Verify folder selection, alias input, and auto-mount sections work correctly
  • Verify the identicon style matches other places in the UI (e.g., VFolderNodes list)

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 1, 2026 01:46
@github-actions github-actions bot added the size:S 10~30 LoC label Apr 1, 2026
Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.69% (+0.03% 🔼)
1548/17816
🔴 Branches
7.55% (-0.05% 🔻)
940/12458
🔴 Functions
5.64% (+0.03% 🔼)
278/4929
🔴 Lines
8.37% (+0.02% 🔼)
1452/17339
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / useModelCardMetadata.tsx
0% 0% 0% 0%

Test suite run success

784 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from 7dd708c

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a deterministic identicon next to each folder name in VFolderTable so mounted folders (and other rows shown by this table) have a visual identifier consistent with other vfolder UIs.

Changes:

  • Import Dicebear shapes / createAvatar into VFolderTable.
  • Render an inline identicon <img> next to the folder name link in the Name column.

@ironAiken2
Copy link
Copy Markdown
Contributor Author

All 3 Copilot feedback items have been addressed: the inline Dicebear createAvatar code was replaced with the existing VFolderNodeIdenticon Relay fragment component, which:

  1. Eliminates code duplication (feedback Initialization and testing #1)
  2. Handles memoization via Relay fragment caching (feedback Add UI backbone frame #2)
  3. Manages accessibility attributes internally (feedback Job list query #3)

@ironAiken2 ironAiken2 force-pushed the 04-01-fix_fr-2420_add_missing_identicon_for_mount_folders_in_vfoldertable branch from 4367661 to a01a1af Compare April 1, 2026 08:54
@github-actions github-actions bot added ux-feedback size:L 100~500 LoC and removed size:S 10~30 LoC labels Apr 1, 2026
@ironAiken2 ironAiken2 force-pushed the 04-01-fix_fr-2420_add_missing_identicon_for_mount_folders_in_vfoldertable branch from a01a1af to 7dd708c Compare April 1, 2026 09:03
@ironAiken2 ironAiken2 requested a review from Copilot April 1, 2026 09:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

react/src/components/VFolderTable.tsx:347

  • Avoid empty catch handlers: internalForm.validateFields().catch(() => {}) silently swallows validation errors and is flagged as a security/diagnostic concern in this codebase. If errors are intentionally ignored, make that explicit (e.g., return undefined) or log at an appropriate level so unexpected failures aren’t hidden.
    onChangeAliasMap?.(
      _.mapValues(
        _.pickBy(internalForm.getFieldsValue({ strict: false }), (v) => !!v), //remove empty
        (v, k) => inputToAliasPath(k, v), // add alias base path
      ),
    );
    internalForm.validateFields().catch(() => {});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing identicon for additional mount folders in ModelService creation

2 participants