Skip to content

chore(FR-2426): remove redundant info icon from keypair policy table#6310

Open
yomybaby wants to merge 1 commit intomainfrom
chore/FR-2426-remove-redundant-info-icon
Open

chore(FR-2426): remove redundant info icon from keypair policy table#6310
yomybaby wants to merge 1 commit intomainfrom
chore/FR-2426-remove-redundant-info-icon

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented Apr 1, 2026

Resolves #6300(FR-2426)

Summary

  • Remove the redundant info (i) icon from keypair resource policy table
  • The info modal showed the same content as the edit modal, making it unnecessary
  • Delete KeypairResourcePolicyInfoModal.tsx and all related state/imports from KeypairResourcePolicyList.tsx

Test plan

  • Go to resource-policy page, keypair tab
  • Verify the info (i) icon is no longer present in the table action column
  • Verify edit functionality still works correctly

Screenshots

After (info icon removed)
after

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 1, 2026 05:08
@github-actions github-actions bot added the size:L 100~500 LoC label Apr 1, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented Apr 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Apr 1, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Lablup Agent seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the now-redundant “info” affordance from the Keypair Resource Policy table by deleting the dedicated info modal and stripping its associated Relay fragment/state from the list view.

Changes:

  • Removed the Info (ⓘ) action button from the Keypair Resource Policy table controls.
  • Removed KeypairResourcePolicyInfoModal usage and related state/transition logic from KeypairResourcePolicyList.
  • Deleted KeypairResourcePolicyInfoModal.tsx and removed its Relay fragment spread from the list query.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
react/src/components/KeypairResourcePolicyList.tsx Drops the info icon/button, removes info-modal state, and removes the info fragment spread from the query.
react/src/components/KeypairResourcePolicyInfoModal.tsx Removes the unused info modal component entirely.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.68% (+0.01% 🔼)
1548/17835
🔴 Branches
7.61% (+0.02% 🔼)
940/12349
🔴 Functions
5.61% (+0.01% 🔼)
278/4952
🔴 Lines
8.37% (+0.01% 🔼)
1452/17355

Test suite run success

784 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from 24e0de7

yomybaby pushed a commit that referenced this pull request Apr 1, 2026
The info modal showed the same content as the edit modal, making it
redundant. Remove the InfoCircleOutlined button from the control column
and delete the KeypairResourcePolicyInfoModal component entirely.
@yomybaby yomybaby force-pushed the chore/FR-2426-remove-redundant-info-icon branch from dd3ebfd to 24e0de7 Compare April 2, 2026 00:55
@github-actions github-actions bot added the type:chore Maintenance tasks (build, CI, etc.) label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC type:chore Maintenance tasks (build, CI, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(FR-2426): Remove redundant info icon from keypair policy table

2 participants