e2e(FR-2434): add E2E test for allowed IP restriction enforcement during active session#6318
Open
ironAiken2 wants to merge 2 commits intomainfrom
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Playwright E2E spec under e2e/user-profile/ to verify that Allowed Client IP restrictions are enforced even for an already-authenticated user once the admin updates the allowed list.
Changes:
- Introduces a serial E2E flow that creates a user, captures the user’s current client IP, allows it, verifies access, then revokes it and verifies access is denied.
- Adds cleanup steps to remove the restriction and purge the created test user.
ironAiken2
force-pushed
the
04-01-e2e_fr-2434_add_e2e_test_for_allowed_ip_restriction_enforcement_during_active_session
branch
from
8e03a39 to
9c95d5a
Compare
nowgnuesLee
requested changes
Apr 2, 2026
Contributor
nowgnuesLee
left a comment
nowgnuesLee
left a comment
There was a problem hiding this comment.
Please update webm files too.
…ing active session
…stability - Add clickRowAction helper to handle icon-only buttons in BAINameActionCell - Fix Edit button locator using icon aria-label instead of button name - Fix Deactivate action: remove incorrect popconfirm expectation (mutation fires directly) - Fix cleanup test: use dispatchEvent for checkbox click to handle table re-renders - Increase cleanup test timeout to 60s for reliability Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ironAiken2
force-pushed
the
04-01-e2e_fr-2434_add_e2e_test_for_allowed_ip_restriction_enforcement_during_active_session
branch
from
9c95d5a to
ea5776c
Compare
ironAiken2
added a commit
that referenced
this pull request
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6316 (FR-2434)
Summary
browser.newContext()) to maintain simultaneous admin and user sessionsKnown Issue
Due to a
purge_userAPI error (user_uuid must be set for RBAC validation), test users created during the test run may not be permanently deleted. The cleanup step only deactivates the user. If you need full cleanup, please use a manager version 26.4.0 or above, or modifysrc/lib/backend.ai-client-esm.tsto adjust the feature flag accordingly.Test Recordings
Test plan
npx playwright test e2e/user-profile/user-ip-restriction-enforcement.spec.tsagainst a local Backend.AI cluster🤖 Generated with Claude Code