Skip to content

feat(FR-2417): add admin model card management page with CRUD#6330

Draft
agatha197 wants to merge 1 commit intospec/admin-model-card-managementfrom
04-01-feat_fr-2417_add_admin_model_card_management_page_with_crud
Draft

feat(FR-2417): add admin model card management page with CRUD#6330
agatha197 wants to merge 1 commit intospec/admin-model-card-managementfrom
04-01-feat_fr-2417_add_admin_model_card_management_page_with_crud

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented Apr 1, 2026

Resolves #6328 (FR-2417) #6329 (FR-2417)

Summary

  • Add new admin-only page at /admin-model-store for managing model cards via the ModelCardV2 GraphQL API
  • AdminModelCardListPage: BAITable with pagination, name filtering (BAIGraphQLPropertyFilter), sorting (name, created_at), and delete action (adminDeleteModelCardV2)
  • AdminModelCardSettingModal: combined create/edit modal using adminCreateModelCardV2 and adminUpdateModelCardV2 mutations
  • Route registration with superadmin-only access, menu item in superadmin operations group
  • i18n keys under adminModelCard namespace

Backend Dependency

Based on backend.ai#10703model_cards table with full CRUD stack.

TODO(needs-backend) — deferred to follow-up PRs:

  • GQL CreateModelCardV2Input / UpdateModelCardV2Input expansion for all metadata fields (currently only name/description for update)
  • Visibility field (public/private toggle) — not in model_cards table yet
  • Service definition fields (runtime, GPU config) — not in backend yet

Verification

=== Relay: PASS ===
=== Lint: PASS ===
=== Format: PASS ===
=== TypeScript: PASS ===
=== ALL PASS ===

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Apr 1, 2026
Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
8.61% (-0.05% 🔻)
1548/17973
🔴 Branches
7.55% (-0.04% 🔻)
940/12450
🔴 Functions
5.56% (-0.04% 🔻)
278/4999
🔴 Lines
8.3% (-0.04% 🔻)
1452/17489
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / AdminModelCardSettingModal.tsx
0% 0% 0% 0%
🔴
... / AdminModelCardListPage.tsx
0% 0% 0% 0%

Test suite run success

784 tests passing in 37 suites.

Report generated by 🧪jest coverage report action from 3124821

@agatha197 agatha197 force-pushed the 04-01-feat_fr-2417_add_admin_model_card_management_page_with_crud branch 2 times, most recently from df6934c to 3124821 Compare April 1, 2026 11:28
@github-actions github-actions bot added the area:lib Library and SDK related issue. label Apr 1, 2026
@agatha197 agatha197 force-pushed the 04-01-feat_fr-2417_add_admin_model_card_management_page_with_crud branch from 3124821 to db87825 Compare April 2, 2026 11:21
Add new admin-only page at /admin-model-store for managing model cards
via the ModelCardV2 GraphQL API (requires backend >= 26.5.0).

- AdminModelCardListPage: table with pagination, filtering (name),
  sorting (name, created_at), and delete action
- AdminModelCardSettingModal: combined create/edit modal using
  adminCreateModelCardV2 and adminUpdateModelCardV2 mutations
- Route registration at /admin-model-store with superadmin-only access
- Menu item gated behind model-card-v2 feature flag (26.5.0+)
- i18n keys for adminModelCard namespace

Resolves #6328 #6329

TODO(needs-backend):
- GQL CreateInput/UpdateInput expansion for all metadata fields
- Visibility field for public/private toggle
- Service definition fields for runtime/GPU configuration
@agatha197 agatha197 force-pushed the 04-01-feat_fr-2417_add_admin_model_card_management_page_with_crud branch from db87825 to 5052495 Compare April 2, 2026 12:02
@agatha197 agatha197 marked this pull request as ready for review April 2, 2026 12:02
Copilot AI review requested due to automatic review settings April 2, 2026 12:03
@agatha197 agatha197 requested review from yomybaby and removed request for Copilot April 2, 2026 12:06
@agatha197 agatha197 marked this pull request as draft April 2, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:lib Library and SDK related issue. area:ux UI / UX issue. size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant