Skip to content

fix: update e2e tests for renamed resource policy modal titles#6333

Merged
yomybaby merged 1 commit intomainfrom
04-01-fix_update_e2e_tests_for_renamed_resource_policy_modal_titles
Apr 2, 2026
Merged

fix: update e2e tests for renamed resource policy modal titles#6333
yomybaby merged 1 commit intomainfrom
04-01-fix_update_e2e_tests_for_renamed_resource_policy_modal_titles

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented Apr 1, 2026

Stacked on #6315

Summary

Test plan

  • npx playwright test e2e/resource-policy/resource-policy.spec.ts — 10/10 pass

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings April 1, 2026 16:00
@github-actions github-actions bot added the size:XS ~10 LoC label Apr 1, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented Apr 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Apr 1, 2026

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Playwright E2E coverage for the Resource Policy page to reflect recently renamed “Create … Resource Policy” modal titles, keeping the e2e/resource-policy CRUD tests aligned with the current UI text (locale en-US in playwright.config.ts).

Changes:

  • Update the Keypair policy creation test to assert the dialog title Create Keypair Resource Policy.
  • Update the User policy creation test to assert the dialog title Create User Resource Policy.

Base automatically changed from feat_fr-2428_add_policy_type_prefix_to_resource_policy_modal_titles to main April 2, 2026 01:23
@yomybaby yomybaby force-pushed the 04-01-fix_update_e2e_tests_for_renamed_resource_policy_modal_titles branch from 10bd6b0 to 94cd4d5 Compare April 2, 2026 09:57
@yomybaby yomybaby merged commit 35df75f into main Apr 2, 2026
8 checks passed
@yomybaby yomybaby deleted the 04-01-fix_update_e2e_tests_for_renamed_resource_policy_modal_titles branch April 2, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants