fix(FR-2776): adapt addModelRevision call sites to new schema#7158
Merged
graphite-app[bot] merged 1 commit intoApr 30, 2026
Merged
Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Contributor
Author
5 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the WebUI’s addModelRevision Relay mutations to match the latest GraphQL schema, where revision options are now carried inside AddRevisionInput (and the mutation no longer takes a separate options argument).
Changes:
- Update
DeploymentLauncherPagemutation signature and variables to passoptions.autoActivateinsideinput. - Update
DeploymentAddRevisionModalmutation signature and variables to passoptions.autoActivateinsideinput. - Refresh
data/schema.graphqlto reflect the newaddModelRevisionsignature and related schema updates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| react/src/pages/DeploymentLauncherPage.tsx | Removes $options from the mutation and moves autoActivate under variables.input.options. |
| react/src/components/DeploymentAddRevisionModal.tsx | Removes inline options argument from the mutation and moves autoActivate under variables.input.options. |
| data/schema.graphql | Adds options to AddRevisionInput and removes the options argument from addModelRevision (plus additional schema refresh changes). |
Comments suppressed due to low confidence (1)
data/schema.graphql:182
- The docstring for
AddRevisionOptionsstill refers to theadd_model_revisionmutation name, but the mutation exposed in this schema isaddModelRevision. Updating the wording here will reduce confusion for schema consumers (and matches the actual field name).
options: AddRevisionOptions = null
}
"""Added in 26.4.2. Options for the add_model_revision mutation."""
input AddRevisionOptions
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 8.12% (+0% 🔼) |
1859/22905 |
| 🔴 | Branches | 7.35% | 1187/16156 |
| 🔴 | Functions | 4.83% (+0.02% 🔼) |
297/6154 |
| 🔴 | Lines | 7.89% (+0% 🔼) |
1750/22190 |
Test suite run success
865 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from 3a901b2
69b4380 to
ecdd93b
Compare
a2f6de7 to
6350b34
Compare
12 tasks
Merge activity
|
Resolves #7157 ([FR-2776](https://lablup.atlassian.net/browse/FR-2776)) > Stacks on top of #7153 (FR-2773) → #7152 (FR-2774). ## Symptom Relay compile errors after a schema sync: ``` ✖︎ Unknown argument 'options'. react/src/components/DeploymentAddRevisionModal.tsx:172:41 react/src/pages/DeploymentLauncherPage.tsx:259:41 ``` ## Schema change `addModelRevision` no longer takes `options` as a top-level mutation argument. The `AddRevisionOptions` payload is now a field on `AddRevisionInput`: ```graphql # Before addModelRevision(input: AddRevisionInput!, options: AddRevisionOptions): AddRevisionPayload! # After addModelRevision(input: AddRevisionInput!): AddRevisionPayload! # AddRevisionInput now has: options: AddRevisionOptions = null ``` ## Changes ### `react/src/pages/DeploymentLauncherPage.tsx` - `DeploymentLauncherPageEditMutation`: drop the `$options: AddRevisionOptions` variable and the `, options: $options` argument from the `addModelRevision` selection. - `handleAddRevision`: move `options: { autoActivate: true }` from `variables` (top level) into `variables.input`. ### `react/src/components/DeploymentAddRevisionModal.tsx` - `DeploymentAddRevisionModalAddMutation`: drop the inline `options: { autoActivate: true }` argument from the `addModelRevision` selection. - `commitAdd`: pass `options: { autoActivate: true }` inside the `input` payload. ### `data/schema.graphql` - Sync to the new server schema (drives Relay compiler against the latest definition). ## Test plan - [x] `pnpm run relay` compiles without errors. - [x] `bash scripts/verify.sh` passes (Relay / Lint / Format / TypeScript). - [ ] `/deployments/create`: create-then-add-revision flow still produces an active revision (auto-activated). - [ ] Standalone Add Revision modal: clicking "Add Revision" creates a new revision and auto-activates it. [FR-2776]: https://lablup.atlassian.net/browse/FR-2776?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
ecdd93b to
ab6e4b0
Compare
6350b34 to
3a901b2
Compare
Base automatically changed from
04-29-fix_fr-2773_preserve_auto-selected_resourcepresetid_across_applyinitialvalues
to
main
April 30, 2026 07:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves #7157 (FR-2776)
Symptom
Relay compile errors after a schema sync:
Schema change
addModelRevisionno longer takesoptionsas a top-level mutation argument. TheAddRevisionOptionspayload is now a field onAddRevisionInput:Changes
react/src/pages/DeploymentLauncherPage.tsxDeploymentLauncherPageEditMutation: drop the$options: AddRevisionOptionsvariable and the, options: $optionsargument from theaddModelRevisionselection.handleAddRevision: moveoptions: { autoActivate: true }fromvariables(top level) intovariables.input.react/src/components/DeploymentAddRevisionModal.tsxDeploymentAddRevisionModalAddMutation: drop the inlineoptions: { autoActivate: true }argument from theaddModelRevisionselection.commitAdd: passoptions: { autoActivate: true }inside theinputpayload.data/schema.graphqlTest plan
pnpm run relaycompiles without errors.bash scripts/verify.shpasses (Relay / Lint / Format / TypeScript)./deployments/create: create-then-add-revision flow still produces an active revision (auto-activated).