Skip to content

fix(FR-2818): fall back to legacy model store on managers where PresetExecutionSpec.imageId was renamed#7279

Closed
agatha197 wants to merge 1 commit into
mainfrom
05-07-fix_fr-2818_fall_back_to_legacy_model_store_on_managers_where_presetexecutionspec.imageid_was_renamed
Closed

fix(FR-2818): fall back to legacy model store on managers where PresetExecutionSpec.imageId was renamed#7279
agatha197 wants to merge 1 commit into
mainfrom
05-07-fix_fr-2818_fall_back_to_legacy_model_store_on_managers_where_presetexecutionspec.imageid_was_renamed

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented May 7, 2026

Resolves #7252(FR-2818)

Summary

On managers running 26.4.4rc2+, PresetExecutionSpec.imageId was renamed to image on the server. The Relay fragment in ModelCardDrawer.tsx still queries imageId, which fails with GRAPHQL_VALIDATION_FAILED and breaks the entire /model-store V2 page.

Fix

Reuse the existing model-card-v2 feature flag and disable it at 26.4.4 so consumers fall back to the legacy model-store flow until the V2 fragments migrate to the new field name. Routing in routes.tsx is unchanged — supports('model-card-v2') now returns false on 26.4.4+, so /model-store automatically renders LegacyModelStoreListPage.

Why this approach

The fragment-level rename is a separate, larger change. Disabling the flag is a minimal, version-gated workaround that restores functionality on 26.4.4+ while preserving V2 behavior on 26.4.0–26.4.3.

Copy link
Copy Markdown
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor Author

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is because the server hasn't been updated. I'll close the PR.

@agatha197 agatha197 closed this May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Model Store (/model-store) inaccessible — GraphQL "imageId" rejected on PresetExecutionSpec

1 participant