Skip to content

refactor(FR-2841): rename WSProxy i18n keys/values to App Proxy#7300

Merged
graphite-app[bot] merged 1 commit into
mainfrom
05-08-refactor_fr-2841_rename_wsproxy_i18n_keys_values_to_app_proxy
May 8, 2026
Merged

refactor(FR-2841): rename WSProxy i18n keys/values to App Proxy#7300
graphite-app[bot] merged 1 commit into
mainfrom
05-08-refactor_fr-2841_rename_wsproxy_i18n_keys_values_to_app_proxy

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 8, 2026

Resolves #7298(FR-2841)

Summary

Rename the i18n keys resourceGroup.WsproxyAPIToken and resourceGroup.WsproxyAddress to resourceGroup.AppProxyAPIToken and resourceGroup.AppProxyAddress, and replace the user-facing string WSProxy with App Proxy across all 21 locale files.

This is a rename of the i18n surface only — internal API and method names (closeWsproxy, getWsproxyVersion, wsproxy_addr, wsProxyAddress, wsProxyAPIToken) are intentionally untouched.

Changes

  • 21 locale files under resources/i18n/ — keys renamed, values updated, alphabetically re-sorted within resourceGroup
  • 3 React components updated to call the new keys:
    • react/src/components/ResourceGroupInfoModal.tsx
    • react/src/components/ResourceGroupList.tsx
    • react/src/components/ResourceGroupSettingModal.tsx

Verification

  • bash scripts/verify.sh — Lint PASS, Format PASS. TypeScript failures exist but are pre-existing on main (in packages/backend.ai-client/src/client.ts and src/components/DeleteForeverVFolderModalV2.tsx) and are unrelated to this change.
  • Confirmed no leftover Wsproxy(APIToken|Address) references in *.ts, *.tsx, or *.json files.

Source

Discussion: Teams thread in UX Ideas, References, and Questions

@github-actions github-actions Bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels May 8, 2026
Copy link
Copy Markdown
Member Author

yomybaby commented May 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby force-pushed the 05-08-refactor_fr-2841_rename_wsproxy_i18n_keys_values_to_app_proxy branch from aa32746 to d6cd6fb Compare May 8, 2026 02:49
@yomybaby yomybaby marked this pull request as ready for review May 8, 2026 02:50
Copilot AI review requested due to automatic review settings May 8, 2026 02:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.51% 1783 / 27351
🔵 Statements 5.39% 1978 / 36681
🔵 Functions 5.19% 296 / 5694
🔵 Branches 3.78% 1293 / 34158
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/components/ResourceGroupInfoModal.tsx 0% 0% 0% 0% 20-170
react/src/components/ResourceGroupList.tsx 0% 0% 0% 0% 57-393
react/src/components/ResourceGroupSettingModal.tsx 0% 0% 0% 0% 59-278
Generated in workflow #456 for commit 024fcd9 by the Vitest Coverage Report Action

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Renames the resource-group i18n keys for WSProxy address/token to App Proxy equivalents and updates the corresponding translations, then updates React call sites to reference the new keys.

Changes:

  • Renamed resourceGroup.WsproxyAddressresourceGroup.AppProxyAddress and resourceGroup.WsproxyAPITokenresourceGroup.AppProxyAPIToken across all resources/i18n/* locales.
  • Updated user-facing translated values from “WSProxy …” to “App Proxy …” across the same locale files.
  • Updated ResourceGroup* React components to use the new i18n keys.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
resources/i18n/de.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/el.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/en.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/es.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/fi.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/fr.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/id.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/it.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/ja.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/ko.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/mn.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/ms.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/pl.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/pt.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/pt-BR.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/ru.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/th.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/tr.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/vi.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/zh-CN.json Renamed WSProxy resource group keys to App Proxy and updated translations.
resources/i18n/zh-TW.json Renamed WSProxy resource group keys to App Proxy and updated translations (needs locale-script fix).
react/src/components/ResourceGroupInfoModal.tsx Updated label to use resourceGroup.AppProxyAddress.
react/src/components/ResourceGroupList.tsx Updated table column title to use resourceGroup.AppProxyAddress.
react/src/components/ResourceGroupSettingModal.tsx Updated form labels to use resourceGroup.AppProxyAddress / resourceGroup.AppProxyAPIToken.

Comment thread resources/i18n/zh-TW.json Outdated
@yomybaby yomybaby force-pushed the 05-08-refactor_fr-2841_rename_wsproxy_i18n_keys_values_to_app_proxy branch from d6cd6fb to 2c64af4 Compare May 8, 2026 02:58
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 8, 2026

Merge activity

Resolves #7298(FR-2841)

## Summary

Rename the i18n keys `resourceGroup.WsproxyAPIToken` and `resourceGroup.WsproxyAddress` to `resourceGroup.AppProxyAPIToken` and `resourceGroup.AppProxyAddress`, and replace the user-facing string `WSProxy` with `App Proxy` across all 21 locale files.

This is a rename of the **i18n surface only** — internal API and method names (`closeWsproxy`, `getWsproxyVersion`, `wsproxy_addr`, `wsProxyAddress`, `wsProxyAPIToken`) are intentionally untouched.

## Changes

- 21 locale files under `resources/i18n/` — keys renamed, values updated, alphabetically re-sorted within `resourceGroup`
- 3 React components updated to call the new keys:
  - `react/src/components/ResourceGroupInfoModal.tsx`
  - `react/src/components/ResourceGroupList.tsx`
  - `react/src/components/ResourceGroupSettingModal.tsx`

## Verification

- `bash scripts/verify.sh` — Lint PASS, Format PASS. TypeScript failures exist but are pre-existing on `main` (in `packages/backend.ai-client/src/client.ts` and `src/components/DeleteForeverVFolderModalV2.tsx`) and are unrelated to this change.
- Confirmed no leftover `Wsproxy(APIToken|Address)` references in `*.ts`, `*.tsx`, or `*.json` files.

## Source

Discussion: [Teams thread in *UX Ideas, References, and Questions*](https://teams.microsoft.com/l/message/19:2806b848642744138244b7358cd282d9@thread.skype/1778140833745?tenantId=13c6a44d-9b52-4b9e-aa34-0513ee7131f2&groupId=ea5c466a-2dcf-4ea7-88f8-a9a797f66903&parentMessageId=1778137938349&teamName=Lablup&channelName=UX%20Ideas%2C%20References%2C%20and%20Questions&createdTime=1778140833745)
@graphite-app graphite-app Bot force-pushed the 05-08-refactor_fr-2841_rename_wsproxy_i18n_keys_values_to_app_proxy branch from 2c64af4 to 024fcd9 Compare May 8, 2026 05:39
@graphite-app graphite-app Bot merged commit 024fcd9 into main May 8, 2026
11 checks passed
@graphite-app graphite-app Bot deleted the 05-08-refactor_fr-2841_rename_wsproxy_i18n_keys_values_to_app_proxy branch May 8, 2026 05:40
@github-pages github-pages Bot temporarily deployed to github-pages May 8, 2026 05:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. i18n size:L 100~500 LoC ui-text

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename i18n WsproxyAPIToken/WsproxyAddress keys and update their values

2 participants