feat(FR-2858): add revision number display and expand filter/sort in revision history tab#7336
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
7c0ca89 to
278daf8
Compare
278daf8 to
40131f9
Compare
There was a problem hiding this comment.
Pull request overview
This PR syncs the WebUI GraphQL schema with recent backend changes (notably adding revisionNumber to ModelRevision) and surfaces revision numbers throughout the deployment revision UI to improve identification, sorting, and filtering in the revision history tab.
Changes:
- Updated revision history table to display
#Nalongside a copyable ID, and expanded sortable/filterable fields (including UUID-validated filters). - Updated deployment revision detail/notification UI to prefer revision numbers over raw UUIDs.
- Synced
data/schema.graphqlwith backend changes and added i18n keys across all supported locales.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| data/schema.graphql | Sync schema with backend updates (adds ModelRevision.revisionNumber, adjusts nullability, introduces handler-options policy types). |
| react/src/components/DeploymentConfigurationSection.tsx | Uses revision number in “deploying revision” alert text (fallback to local ID). |
| react/src/components/DeploymentRevisionDetail.tsx | Displays revision number as the primary field; makes revision ID copyable. |
| react/src/components/DeploymentRevisionHistoryTab.tsx | Adds revision number + ID display, new sort keys/columns, and expanded filters including UUID validation. |
| resources/i18n/de.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/el.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/en.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/es.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/fi.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/fr.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/id.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/it.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/ja.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/ko.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/mn.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/ms.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/pl.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/pt-BR.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/pt.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/ru.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/th.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/tr.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/vi.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/zh-CN.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
| resources/i18n/zh-TW.json | Adds deployment.RevisionNumberWithID and general.InvalidUUID; updates deploying message placeholder. |
40131f9 to
c7855fa
Compare
nowgnuesLee
left a comment
There was a problem hiding this comment.
LGTM but please restack this pr.
c7855fa to
b649284
Compare
Merge activity
|
…revision history tab (#7336) Resolves #7335 ([FR-2858](https://lablup.atlassian.net/browse/FR-2858)) ## Summary - Sync `data/schema.graphql` with backend.ai PR #11529 which adds `revisionNumber: Int!` to `ModelRevision` and various nullability adjustments - Revision history table now shows `#N (uuid [copy])` format using `BAIId` component for easy identification and UUID copying - Extended sortable columns: revision number, created-at, resource group, cluster mode, runtime variant name - Added filters: revision number (number), created-at (datetime), resource group (string), cluster mode (string), image ID (uuid), model vfolder ID (uuid); UUID filters use `isValidUUID` validator - Added Image column (defaultHidden) showing canonical name + copyable UUID via `BAIId` - Added Model Folder column (defaultHidden) showing folder name + copyable UUID via `BAIId` - `DeployingRevisionApplying` notification now uses `#N` revision number instead of raw UUID - `DeploymentRevisionDetail` now displays revision number as the first field - Added `general.InvalidUUID` and `deployment.RevisionNumberWithID` i18n keys across 21 languages [FR-2858]: https://lablup.atlassian.net/browse/FR-2858?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
b649284 to
2dc90c3
Compare

Resolves #7335 (FR-2858)
Summary
data/schema.graphqlwith backend.ai PR #11529 which addsrevisionNumber: Int!toModelRevisionand various nullability adjustments#N (uuid [copy])format usingBAIIdcomponent for easy identification and UUID copyingisValidUUIDvalidatorBAIIdBAIIdDeployingRevisionApplyingnotification now uses#Nrevision number instead of raw UUIDDeploymentRevisionDetailnow displays revision number as the first fieldgeneral.InvalidUUIDanddeployment.RevisionNumberWithIDi18n keys across 21 languages