Skip to content

fix(FR-2885): remove hard-coded fontSize on UserDropdownMenu avatar icon#7394

Merged
yomybaby merged 1 commit into
mainfrom
05-13-fix_fr-2885_remove_hard-coded_fontsize_on_userdropdownmenu_avatar_icon
May 13, 2026
Merged

fix(FR-2885): remove hard-coded fontSize on UserDropdownMenu avatar icon#7394
yomybaby merged 1 commit into
mainfrom
05-13-fix_fr-2885_remove_hard-coded_fontsize_on_userdropdownmenu_avatar_icon

Conversation

@yomybaby
Copy link
Copy Markdown
Member

@yomybaby yomybaby commented May 13, 2026

Resolves #7393 (FR-2885)

Summary

  • Remove the hard-coded fontSize: 10 on <UserOutlined /> inside the UserDropdownMenu avatar so the icon scales naturally with the 17px Avatar instead of rendering as a tiny glyph.

Test plan

  • Verify the user icon in the header dropdown renders at a normal size and is centered within the avatar.

Copilot AI review requested due to automatic review settings May 13, 2026 01:07
@github-actions github-actions Bot added the size:XS ~10 LoC label May 13, 2026
Copy link
Copy Markdown
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a hard-coded fontSize style from the user avatar icon in the UserDropdownMenu button to better rely on inherited sizing/styling (improving consistency across themes and typography settings).

Changes:

  • Removed the inline fontSize: 10 style from the UserOutlined icon rendered inside the dropdown trigger Avatar.

Comment thread react/src/components/UserDropdownMenu.tsx
@github-actions
Copy link
Copy Markdown
Contributor

Coverage Report for react-coverage (./react)

Status Category Percentage Covered / Total
🔵 Lines 6.45% 1783 / 27614
🔵 Statements 5.31% 1978 / 37250
🔵 Functions 5.18% 296 / 5709
🔵 Branches 3.71% 1293 / 34798
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
react/src/components/UserDropdownMenu.tsx 0% 0% 0% 0% 46-269
Generated in workflow #593 for commit 09836d2 by the Vitest Coverage Report Action

@yomybaby yomybaby merged commit adaa5a0 into main May 13, 2026
18 checks passed
@yomybaby yomybaby deleted the 05-13-fix_fr-2885_remove_hard-coded_fontsize_on_userdropdownmenu_avatar_icon branch May 13, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User icon in UserDropdownMenu rendered too small

2 participants