refactor(BA-5040): Remove RBAC validator from SearchImagesAction

Revert SearchImagesAction to plain ImageAction without scope
metadata. Remove user_uuid/domain_name fields, scope methods,
and switch processor back to ActionProcessor.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: fregataa

src/ai/backend/manager/api/gql/data_loader/image/loader.py

@@ -2,7 +2,6 @@
 
 from collections.abc import Sequence
 
-from ai.backend.common.contexts.user import current_user
 from ai.backend.common.types import ImageID
 from ai.backend.manager.data.image.types import ImageData
 from ai.backend.manager.repositories.base import BatchQuerier, NoPagination
@@ -32,9 +31,8 @@ async def load_images_by_ids(
         conditions=[ImageConditions.by_ids(image_ids)],
     )
 
-    user = current_user()
     action_result = await processor.search_images.wait_for_complete(
-        SearchImagesAction(querier=querier, user_uuid=str(user.user_id) if user else "")
+        SearchImagesAction(querier=querier)
     )
 
     image_map: dict[ImageID, ImageData] = {ImageID(image.id): image for image in action_result.data}

src/ai/backend/manager/api/gql/image/fetcher.py

@@ -12,7 +12,6 @@
 import strawberry
 from strawberry import Info
 
-from ai.backend.common.contexts.user import current_user
 from ai.backend.common.types import ImageID
 from ai.backend.manager.api.gql.adapter import PaginationOptions, PaginationSpec
 from ai.backend.manager.api.gql.base import encode_cursor
@@ -85,9 +84,8 @@ async def fetch_images(
         base_conditions=base_conditions,
     )
 
-    user = current_user()
     action_result = await info.context.processors.image.search_images.wait_for_complete(
-        SearchImagesAction(querier=querier, user_uuid=str(user.user_id) if user else "")
+        SearchImagesAction(querier=querier)
     )
 
     edges = []

src/ai/backend/manager/api/rest/image/handler.py

@@ -56,10 +56,7 @@ async def search(
         log.info("SEARCH (ak:{})", ctx.access_key)
         querier = self._adapter.build_querier(body.parsed)
         action_result = await self._image.search_images.wait_for_complete(
-            SearchImagesAction(
-                querier=querier,
-                user_uuid=str(ctx.user_uuid),
-            )
+            SearchImagesAction(querier=querier)
         )
         resp = SearchImagesResponse(
             items=[self._adapter.convert_to_dto(img) for img in action_result.data],

src/ai/backend/manager/services/image/actions/search_images.py

@@ -3,50 +3,34 @@
 from dataclasses import dataclass
 from typing import override
 
-from ai.backend.common.data.permission.types import RBACElementType, ScopeType
+from ai.backend.manager.actions.action import BaseActionResult
 from ai.backend.manager.actions.types import ActionOperationType
 from ai.backend.manager.data.image.types import ImageData
-from ai.backend.manager.data.permission.types import RBACElementRef
 from ai.backend.manager.repositories.base import BatchQuerier
-from ai.backend.manager.services.image.actions.base import ImageScopeAction, ImageScopeActionResult
+from ai.backend.manager.services.image.actions.base import ImageAction
 
 
 @dataclass
-class SearchImagesAction(ImageScopeAction):
+class SearchImagesAction(ImageAction):
     querier: BatchQuerier
-    user_uuid: str
+
+    @override
+    def entity_id(self) -> str | None:
+        return None
 
     @override
     @classmethod
     def operation_type(cls) -> ActionOperationType:
         return ActionOperationType.SEARCH
 
-    @override
-    def scope_type(self) -> ScopeType:
-        # Images are scoped to the user
-        return ScopeType.USER
-
-    @override
-    def scope_id(self) -> str:
-        return self.user_uuid
-
-    @override
-    def target_element(self) -> RBACElementRef:
-        return RBACElementRef(RBACElementType.USER, self.user_uuid)
-
 
 @dataclass
-class SearchImagesActionResult(ImageScopeActionResult):
+class SearchImagesActionResult(BaseActionResult):
     data: list[ImageData]
     total_count: int
     has_next_page: bool
     has_previous_page: bool
-    user_uuid: str = ""
-
-    @override
-    def scope_type(self) -> ScopeType:
-        return ScopeType.USER
 
     @override
-    def scope_id(self) -> str:
-        return self.user_uuid
+    def entity_id(self) -> str | None:
+        return None

src/ai/backend/manager/services/image/processors.py

@@ -132,7 +132,7 @@ class ImageProcessors(AbstractProcessorPackage):
         GetImageInstalledAgentsAction, GetImageInstalledAgentsActionResult
     ]
     get_all_images: ScopeActionProcessor[GetAllImagesAction, GetAllImagesActionResult]
-    search_images: ScopeActionProcessor[SearchImagesAction, SearchImagesActionResult]
+    search_images: ActionProcessor[SearchImagesAction, SearchImagesActionResult]
     search_aliases: ActionProcessor[SearchAliasesAction, SearchAliasesActionResult]
     load_image_last_used: ActionProcessor[LoadImageLastUsedAction, LoadImageLastUsedActionResult]
 
@@ -159,9 +159,7 @@ def __init__(
         self.get_all_images = ScopeActionProcessor(
             service.get_all_images, action_monitors, validators=[validators.rbac.scope]
         )
-        self.search_images = ScopeActionProcessor(
-            service.search_images, action_monitors, validators=[validators.rbac.scope]
-        )
+        self.search_images = ActionProcessor(service.search_images, action_monitors)
 
         # Single entity actions with RBAC validation
         self.forget_image_by_id = SingleEntityActionProcessor(

src/ai/backend/manager/services/image/service.py

@@ -402,7 +402,6 @@ async def search_images(self, action: SearchImagesAction) -> SearchImagesActionR
             total_count=result.total_count,
             has_next_page=result.has_next_page,
             has_previous_page=result.has_previous_page,
-            user_uuid=action.user_uuid,
         )
 
     async def alias_image_by_id(self, action: AliasImageByIdAction) -> AliasImageByIdActionResult:

tests/unit/manager/api/image/test_handler.py

@@ -428,7 +428,7 @@ async def test_search_images_calls_processor(
     ) -> None:
         """Search handler should call search_images processor."""
         await mock_processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
+            SearchImagesAction(querier=MagicMock())
         )
         mock_processors.image.search_images.wait_for_complete.assert_called_once()
 
@@ -438,7 +438,7 @@ async def test_search_images_returns_correct_count(
     ) -> None:
         """Search result should have correct total count."""
         result = await mock_processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
+            SearchImagesAction(querier=MagicMock())
         )
         assert result.total_count == 2
         assert len(result.data) == 2
@@ -449,7 +449,7 @@ async def test_search_images_converts_to_dto(
     ) -> None:
         """Search result data should be convertible to DTOs."""
         result = await mock_processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
+            SearchImagesAction(querier=MagicMock())
         )
         adapter = ImageAdapter()
         items = [adapter.convert_to_dto(img) for img in result.data]
@@ -591,7 +591,7 @@ async def test_search_empty_result(self) -> None:
         processors.image.search_images.wait_for_complete = AsyncMock(return_value=result)
 
         search_result = await processors.image.search_images.wait_for_complete(
-            SearchImagesAction(querier=MagicMock(), user_uuid="test-user")
+            SearchImagesAction(querier=MagicMock())
         )
         assert search_result.data == []
         assert search_result.total_count == 0

tests/unit/manager/services/image/test_image_service.py

@@ -903,7 +903,7 @@ async def test_search_images_success(
             conditions=[],
             orders=[],
         )
-        action = SearchImagesAction(querier=querier, user_uuid="test-user")
+        action = SearchImagesAction(querier=querier)
 
         result = await processors.search_images.wait_for_complete(action)
 
@@ -933,7 +933,7 @@ async def test_search_images_empty_result(
             conditions=[],
             orders=[],
         )
-        action = SearchImagesAction(querier=querier, user_uuid="test-user")
+        action = SearchImagesAction(querier=querier)
 
         result = await processors.search_images.wait_for_complete(action)
 
@@ -961,7 +961,7 @@ async def test_search_images_with_pagination(
             conditions=[],
             orders=[],
         )
-        action = SearchImagesAction(querier=querier, user_uuid="test-user")
+        action = SearchImagesAction(querier=querier)
 
         result = await processors.search_images.wait_for_complete(action)