refactor(BA-5982): drop deployment_revision adapter split

Roll back the dedicated ``DeploymentRevisionAdapter`` introduced earlier
in this PR. Adapter / handler / processor for the bulk admin refresh all
live back inside the single ``deployment`` slice; the service-side
helper ``_build_creator_from_revision_data`` and the inline
``admin_refresh_deployment_revisions`` loop are restored to their
pre-split form, and ``RefreshDeploymentRevisionsAction`` returns to the
no-arg shape that triggers the service to do the whole sweep on its
own. ``DeploymentAdapter`` is again the single owner of revision-side
adapter methods including ``admin_refresh_deployment_revisions``; the
GQL resolver and REST handler call it directly with no extra
``revision_adapter`` injection.

Other refactor work in this PR (``from_spec`` →
``from_revision_spec``, ``replica_counts`` → ``replica``, the
``ModelRevisionData.deployment_id`` field, the Spec/Data split, the
``revision_number`` exposure) is unaffected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: jopemachine

src/ai/backend/manager/api/adapters/deployment/adapter.py

@@ -67,6 +67,7 @@
     AccessTokenNode,
     ActivateRevisionPayload,
     AddRevisionPayload,
+    AdminRefreshDeploymentRevisionsPayload,
     AdminSearchDeploymentsPayload,
     AdminSearchRevisionsPayload,
     AutoScalingRuleNode,
@@ -86,6 +87,7 @@
     ReplaceDeploymentOptionsPayload,
     ReplicaNode,
     RevisionNode,
+    RevisionRefreshResultInfo,
     RouteNode,
     SearchAccessTokensPayload,
     SearchAutoScalingRulesPayload,
@@ -295,6 +297,9 @@
 from ai.backend.manager.services.deployment.actions.model_revision.search_revisions import (
     SearchRevisionsAction,
 )
+from ai.backend.manager.services.deployment.actions.refresh_deployment_revisions import (
+    RefreshDeploymentRevisionsAction,
+)
 from ai.backend.manager.services.deployment.actions.replace_deployment_options import (
     ReplaceDeploymentOptionsAction,
 )
@@ -780,6 +785,27 @@ async def activate_revision(self, input: ActivateRevisionInput) -> ActivateRevis
             deployment_policy=self._policy_data_to_dto(action_result.deployment_policy),
         )
 
+    async def admin_refresh_deployment_revisions(
+        self,
+    ) -> AdminRefreshDeploymentRevisionsPayload:
+        """Create and activate a fresh revision for every active deployment."""
+        action_result = (
+            await self._processors.deployment.admin_refresh_deployment_revisions.wait_for_complete(
+                RefreshDeploymentRevisionsAction()
+            )
+        )
+        return AdminRefreshDeploymentRevisionsPayload(
+            results=[
+                RevisionRefreshResultInfo(
+                    deployment_id=r.deployment_id,
+                    new_revision_id=r.new_revision_id,
+                    success=r.success,
+                    failure_reason=r.failure_reason,
+                )
+                for r in action_result.results
+            ]
+        )
+
     async def delete(self, input: DeleteDeploymentInput) -> DeleteDeploymentPayload:
         """Delete a deployment."""
         await self._processors.deployment.destroy_deployment.wait_for_complete(

src/ai/backend/manager/api/adapters/deployment_revision/__init__.py

@@ -11,9 +11,6 @@
 from ai.backend.manager.api.adapters.audit_log.adapter import AuditLogAdapter
 from ai.backend.manager.api.adapters.container_registry.adapter import ContainerRegistryAdapter
 from ai.backend.manager.api.adapters.deployment.adapter import DeploymentAdapter
-from ai.backend.manager.api.adapters.deployment_revision.adapter import (
-    DeploymentRevisionAdapter,
-)
 from ai.backend.manager.api.adapters.deployment_revision_preset.adapter import (
     DeploymentRevisionPresetAdapter,
 )
@@ -81,7 +78,6 @@ def __init__(
         audit_log: AuditLogAdapter,
         container_registry: ContainerRegistryAdapter,
         deployment: DeploymentAdapter,
-        deployment_revision: DeploymentRevisionAdapter,
         domain: DomainAdapter,
         fair_share: FairShareAdapter,
         huggingface_registry: HuggingFaceRegistryAdapter,
@@ -123,7 +119,6 @@ def __init__(
         self.audit_log = audit_log
         self.container_registry = container_registry
         self.deployment = deployment
-        self.deployment_revision = deployment_revision
         self.domain = domain
         self.fair_share = fair_share
         self.huggingface_registry = huggingface_registry
@@ -184,7 +179,6 @@ def create(
             audit_log=AuditLogAdapter(processors),
             container_registry=ContainerRegistryAdapter(processors),
             deployment=DeploymentAdapter(processors, deployment_coordinator),
-            deployment_revision=DeploymentRevisionAdapter(processors),
             domain=DomainAdapter(processors),
             fair_share=FairShareAdapter(processors),
             huggingface_registry=HuggingFaceRegistryAdapter(processors),

src/ai/backend/manager/api/adapters/deployment_revision/adapter.py

@@ -289,7 +289,7 @@ async def admin_refresh_deployment_revisions(
     info: Info[StrawberryGQLContext],
 ) -> AdminRefreshDeploymentRevisionsPayload | None:
     check_admin_only()
-    payload = await info.context.adapters.deployment_revision.admin_refresh_deployment_revisions()
+    payload = await info.context.adapters.deployment.admin_refresh_deployment_revisions()
     return AdminRefreshDeploymentRevisionsPayload(
         results=[
             RevisionRefreshResult(

src/ai/backend/manager/api/adapters/registry.py

@@ -61,24 +61,15 @@
 
 if TYPE_CHECKING:
     from ai.backend.manager.api.adapters.deployment.adapter import DeploymentAdapter
-    from ai.backend.manager.api.adapters.deployment_revision.adapter import (
-        DeploymentRevisionAdapter,
-    )
 
 log: Final = BraceStyleAdapter(logging.getLogger(__spec__.name))
 
 
 class V2DeploymentHandler:
     """REST v2 handler for deployment operations."""
 
-    def __init__(
-        self,
-        *,
-        adapter: DeploymentAdapter,
-        revision_adapter: DeploymentRevisionAdapter,
-    ) -> None:
+    def __init__(self, *, adapter: DeploymentAdapter) -> None:
         self._adapter = adapter
-        self._revision_adapter = revision_adapter
 
     # ------------------------------------------------------------------
     # Core deployment CRUD
@@ -277,7 +268,7 @@ async def sync_replicas(
 
     async def admin_refresh_deployment_revisions(self) -> APIResponse:
         """Rebuild and activate a fresh revision for every active deployment."""
-        result = await self._revision_adapter.admin_refresh_deployment_revisions()
+        result = await self._adapter.admin_refresh_deployment_revisions()
         return APIResponse.build(status_code=HTTPStatus.OK, response_model=result)
 
     # ------------------------------------------------------------------

src/ai/backend/manager/api/gql/deployment/resolver/deployment.py

@@ -122,10 +122,7 @@ def build_v2_routes(
     artifact_registry_handler = V2ArtifactRegistryHandler(adapter=adapters.artifact_registry)
     audit_log_handler = V2AuditLogHandler(adapter=adapters.audit_log)
     container_registry_handler = V2ContainerRegistryHandler(adapter=adapters.container_registry)
-    deployment_handler = V2DeploymentHandler(
-        adapter=adapters.deployment,
-        revision_adapter=adapters.deployment_revision,
-    )
+    deployment_handler = V2DeploymentHandler(adapter=adapters.deployment)
     domain_handler = V2DomainHandler(adapter=adapters.domain)
     fair_share_handler = V2FairShareHandler(adapter=adapters.fair_share)
     huggingface_registry_handler = V2HuggingFaceRegistryHandler(

src/ai/backend/manager/api/rest/v2/deployment/handler.py

@@ -1,28 +1,20 @@
-from collections.abc import Mapping
 from dataclasses import dataclass, field
 from typing import override
 
-from ai.backend.common.identifier.deployment import DeploymentID
 from ai.backend.manager.actions.action import BaseActionResult
 from ai.backend.manager.actions.types import ActionOperationType
-from ai.backend.manager.data.deployment.creator import ModelRevisionCreator
 from ai.backend.manager.data.deployment.types import RevisionRefreshResult
 from ai.backend.manager.services.deployment.actions.base import DeploymentBaseAction
 
 
 @dataclass
 class RefreshDeploymentRevisionsAction(DeploymentBaseAction):
-    """Admin-only batch action that adds and activates a fresh revision for
-    each deployment in ``creators_by_id``.
-
-    The adapter layer is responsible for projecting each previous-revision
-    ``ModelRevisionData`` onto a ``ModelRevisionCreator`` before invoking
-    this action; the service does no type conversion of its own. Each
-    deployment is processed independently so a single failure does not
-    abort the rest (partial success by design).
-    """
+    """Admin-only action to refresh revisions for all active deployments.
 
-    creators_by_id: Mapping[DeploymentID, ModelRevisionCreator]
+    Creates a new revision based on each active deployment's current revision
+    and activates it, allowing DeploymentController to re-resolve preset,
+    deployment-config, and model_definition.
+    """
 
     @override
     def entity_id(self) -> str | None:

src/ai/backend/manager/api/rest/v2/tree.py

@@ -183,7 +183,7 @@ class DeploymentProcessors(AbstractProcessorPackage):
         SearchRevisionResourceSlotsAction, SearchRevisionResourceSlotsActionResult
     ]
     activate_revision: ActionProcessor[ActivateRevisionAction, ActivateRevisionActionResult]
-    refresh_deployment_revisions: ActionProcessor[
+    admin_refresh_deployment_revisions: ActionProcessor[
         RefreshDeploymentRevisionsAction, RefreshDeploymentRevisionsActionResult
     ]
 
@@ -273,8 +273,8 @@ def __init__(
             service.search_revision_resource_slots, action_monitors
         )
         self.activate_revision = ActionProcessor(service.activate_revision, action_monitors)
-        self.refresh_deployment_revisions = ActionProcessor(
-            service.refresh_deployment_revisions, action_monitors
+        self.admin_refresh_deployment_revisions = ActionProcessor(
+            service.admin_refresh_deployment_revisions, action_monitors
         )
 
         # Route operations