refactor(BA-5069): Apply RBAC Creator pattern to Kernel#10013
Merged
Conversation
- Add KernelRowCreatorSpec in session/creators.py - Replace raw KernelRow construction with RBACBulkEntityCreator in scheduler - Scope association: Kernel → SESSION (parent scope) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors session enqueueing to create KernelRow records via the RBAC creator pattern, aligning kernel creation with the existing RBAC-scoped session creation flow and associating kernels to their parent session scope.
Changes:
- Add
KernelRowCreatorSpecto wrap pre-builtKernelRowinstances for creator-based inserts. - Replace direct
db_sess.add_all(kernels)+flush()withRBACBulkEntityCreator+execute_rbac_bulk_entity_creatorinenqueue_session(). - Create RBAC scope associations that link each kernel to its parent
SESSION.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ai/backend/manager/repositories/session/creators.py |
Adds KernelRowCreatorSpec to support creator-based insertion of pre-built KernelRows. |
src/ai/backend/manager/repositories/scheduler/db_source/db_source.py |
Switches kernel insertion during enqueue_session() to RBAC bulk creation and associates kernels to the session scope. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jopemachine
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KernelRowCreatorSpecinsession/creators.pyfollowing the same wrap-pre-built-row pattern asSessionRowCreatorSpecdb_sess.add_all(kernels)+flush()withRBACBulkEntityCreator+execute_rbac_bulk_entity_creatorinenqueue_session()Test plan
pants lintpassesResolves BA-5069