feat(BA-3693): Apply RBAC validator for App config actions#10028
Merged
Conversation
github-actions
Bot
added
size:S
fregataa
added a commit
that referenced
this pull request
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Applies RBAC scope validation to all app config action processors so app config operations enforce permission checks consistently at the processor layer.
Changes:
- Added
validators=[validators.rbac.scope]to 7ScopeActionProcessorinstances for app config operations. - Ensures domain/user/merged app config actions go through RBAC scope validation before execution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add validators=[validators.rbac.scope] to all ScopeActionProcessor instances - Apply RBAC validation to all 7 app config actions: - Domain config: get, upsert, delete - User config: get, upsert, delete - Merged config: get All app config actions are scope-based (no single-entity actions), so only scope validators are applied. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
jopemachine
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validators.rbac.scopeto 7ScopeActionProcessorinstances covering all app config operations (domain config get/upsert/delete, user config get/upsert/delete, merged config get)AppConfigScopeActionbase class with required RBAC methods from previous refactoringTest plan
pants fmtpassespants fixpassespants lint --changed-since=origin/mainpassesResolves BA-3693