feat(BA-5119): add Strawberry GQL node type for ContainerRegistry#10093
Merged
Conversation
github-actions
Bot
added
size:L
fregataa
added a commit
that referenced
this pull request
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class Strawberry GraphQL node support for container registries and wires it into the RBAC entity-resolution flow so EntityRef.entity can return a ContainerRegistry node.
Changes:
- Introduce
ContainerRegistryGQL(RelayNode) andContainerRegistryTypeGQLenum under a newapi/gql/container_registry/package. - Add
ContainerRegistryGQLto theEntityNodeunion. - Implement
RBACElementType.CONTAINER_REGISTRYresolution inEntityRefGQL.entity()viacontainer_registry_loader.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ai/backend/manager/api/gql/rbac/types/entity_node.py | Extends EntityNode union to include ContainerRegistryGQL. |
| src/ai/backend/manager/api/gql/rbac/types/entity.py | Adds CONTAINER_REGISTRY match arm in EntityRefGQL.entity() resolver. |
| src/ai/backend/manager/api/gql/container_registry/types.py | New Strawberry Relay node + enum for container registries, with loader-based resolve_nodes. |
| src/ai/backend/manager/api/gql/container_registry/init.py | Exports the new container registry GraphQL types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fregataa
added a commit
that referenced
this pull request
Mar 17, 2026
fregataa
force-pushed
the
feat/BA-5119-container-registry-gql-node
branch
from
3cc595a to
721ef23
Compare
Add ContainerRegistryGQL and ContainerRegistryTypeGQL types for the GraphQL API. Register ContainerRegistryGQL in the EntityNode union and resolve it in EntityRefGQL.entity() via container_registry_loader. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add name="ContainerRegistryType" to the strawberry enum decorator and use `is not None` for password masking to handle empty strings. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…aph conflict The legacy Graphene schema already defines a ContainerRegistry type. Use ContainerRegistryV2 to avoid INVALID_FIELD_SHARING in federation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: octodog <mu001@lablup.com>
Ensures ContainerRegistryTypeGQL stays in sync with the internal ContainerRegistryType enum to catch drift early. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…esolver Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fregataa
force-pushed
the
feat/BA-5119-container-registry-gql-node
branch
from
1f5f228 to
5141c04
Compare
…stry GQL types Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fregataa
force-pushed
the
feat/BA-5119-container-registry-gql-node
branch
from
5c8a0b6 to
4ab2123
Compare
Co-authored-by: octodog <mu001@lablup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContainerRegistryGQLStrawberry node type andContainerRegistryTypeGQLenum in newapi/gql/container_registry/packageContainerRegistryGQLin theEntityNodeunion for RBAC entity resolutionCONTAINER_REGISTRYmatch case inEntityRefGQL.entity()resolver using the existingcontainer_registry_loaderTest plan
ContainerRegistrytype inEntityNodeunionEntityRefGQL.entity()resolvesCONTAINER_REGISTRYentities correctlyResolves BA-5119
📚 Documentation preview 📚: https://sorna--10093.org.readthedocs.build/en/10093/
📚 Documentation preview 📚: https://sorna-ko--10093.org.readthedocs.build/ko/10093/