Conversation
…omain-scoped Replace deprecated scope_type='global' permission rows with domain-scoped equivalents (one row per active domain), preserving role_id, entity_type, and operation values. Uses ON CONFLICT DO NOTHING to handle pre-existing domain-scoped permissions gracefully. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
size:M
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Alembic migration to eliminate deprecated scope_type='global' rows in permissions by duplicating them as domain-scoped permissions (one per domain) and then deleting the original global rows. This supports the ongoing RBAC move away from “global” scope.
Changes:
- Introduces a new Alembic revision to convert
permissions.scope_type='global'intoscope_type='domain'across domains. - Uses conflict-handling on the permissions uniqueness constraint to avoid duplicate inserts.
- Leaves downgrade as a no-op (non-reversible conversion).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Change down_revision from ffcf0ed13a26 to 0e0723286a7a to resolve multiple Alembic heads and ensure unique constraint exists - Filter domains by is_active to skip inactive domains - Replace nested Python loop with single INSERT...SELECT CROSS JOIN Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scope_type='global'permission rows to domain-scoped equivalentsON CONFLICT DO NOTHINGto handle cases where domain-scoped permissions already existTest plan
pants lintpasses for changed filespants checkpasses for manager packagepants testpasses for RBAC and permission-related testsResolves BA-5309