fix(BA-5557): register appproxy endpoints for deployments entering DEPLOYING via ActivateRevision

[jopemachine]

Summary

• Deployments entering DEPLOYING state via ActivateRevision (bypassing check_pending) were not getting registered with appproxy, causing them to stay DEGRADED
• DeployingProvisioningHandler now directly calls register_endpoint for unregistered deployments using deploying_revision_id
• Made register_endpoint public on DeploymentExecutor for cross-handler reuse
• Restored check_pending_deployments name for the pending handler path

Test plan

• Verify deployment via CreateDeployment → AddRevision → ActivateRevision registers endpoint in appproxy
• Verify legacy deployment path (check_pending) still works unchanged
• Verify deployments that already have URLs are skipped (no double registration)

🤖 Generated with Claude Code

Fixes BA-5557

[Copilot]

Pull request overview

Fixes BA-5557 by ensuring deployments that enter DEPLOYING via ActivateRevision (skipping the check_pending path) still get registered with appproxy, preventing them from staying DEGRADED.

Changes:

• Add appproxy endpoint registration to the DEPLOYING/PROVISIONING handler for deployments missing network.url (using deploying_revision_id).
• Update check_pending_deployments() to skip already-registered deployments and to resolve the revision via current_revision_id or deploying_revision_id.
• Make DeploymentExecutor.register_endpoint() public and wire additional dependencies through the coordinator.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/ai/backend/manager/sokovan/deployment/handlers/deploying.py	Pre-registers missing appproxy endpoints during DEPLOYING provisioning and bulk-persists URLs.
src/ai/backend/manager/sokovan/deployment/executor.py	Adjusts pending registration logic (skip when URL exists; revision fallback) and exposes register_endpoint() publicly.
src/ai/backend/manager/sokovan/deployment/coordinator.py	Injects DeploymentExecutor + DeploymentRepository into the deploying provisioning handler.

Comments suppressed due to low confidence (1)

src/ai/backend/manager/sokovan/deployment/executor.py:446

• This method is now public (register_endpoint) but it still sits under a "Private helper methods" section header. Consider updating the section header/comment to avoid confusion about intended API surface (or move register_endpoint above the private helpers section).

    # Private helper methods

    async def register_endpoint(
        self,
        deployment: DeploymentInfo,
        scaling_group_target: ScalingGroupProxyTarget,
        revision_id: UUID,
    ) -> str:
        """Resolve the target revision's model definition and register the endpoint to the app proxy.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.